Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negatives in local links #158

Closed
KhudaDad414 opened this issue Apr 19, 2022 · 2 comments · Fixed by #156
Closed

False negatives in local links #158

KhudaDad414 opened this issue Apr 19, 2022 · 2 comments · Fixed by #156
Labels
bug Something isn't working

Comments

@KhudaDad414
Copy link
Member

KhudaDad414 commented Apr 19, 2022

Describe the bug

Recently introduced check for Links that run weekly gives false negatives in all of the local markdown links.
as you can see in the latest run (https://github.com/asyncapi/generator/runs/6050625807?check_suite_focus=true) all of the local links that point to some section of the same file or other local files, gives 404 error.

Expected behaviour

They should pass since I can click on them and they work perfectly.

Root of the issue

After checking the links with other link checkers online, I see all of them give 404 errors unless the link is opened by a browser. I assume it is some kind of protection against bots by GitHub.

Possible Solution

I guess we should ignore local links?

@KhudaDad414 KhudaDad414 added the bug Something isn't working label Apr 19, 2022
@derberg
Copy link
Member

derberg commented Apr 20, 2022

It is a problem with underlying links validator, have a look at gaurav-nelson/github-action-markdown-link-check#127 and fix is not close to be merged gaurav-nelson/github-action-markdown-link-check#129. We might need to switch back to original action from a fork I created recently as they already fixed the issue gaurav-nelson/github-action-markdown-link-check#132 and maybe we will resolve the problem.

Why I think switching back to original action will work? because to fix the issue, when I created a fork, I fixed things on master, and therefore I was using code base of 1.0.14 that has issues with anchors

@derberg
Copy link
Member

derberg commented Apr 20, 2022

best if you include fix here #156 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants