Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running golangci-lint v1.48.0 using Go 1.17, 1.18 images results in Error: File is not gofmt-ed with -s (gofmt) #699

Closed
atc0005 opened this issue Aug 12, 2022 · 0 comments · Fixed by #700
Closed

Running golangci-lint v1.48.0 using Go 1.17, 1.18 images results in Error: File is not gofmt-ed with -s (gofmt) #699

atc0005 opened this issue Aug 12, 2022 · 0 comments · Fixed by #700
Assignees
@atc0005
Labels
bug Something isn't working linting oldstable stable
Milestone
v0.6.22

Comments

@atc0005
Copy link
Owner

atc0005 commented Aug 12, 2022

The gofmt linting functionality appears to use Go 1.19 specific rules instead of the Go version provided by the container where golangci-lint is ran. This will require rolling back to v1.47.x or waiting on an upstream fix.

Refs:
@atc0005 atc0005 added bug Something isn't working oldstable stable linting labels Aug 12, 2022
@atc0005 atc0005 added this to the Next Release milestone Aug 12, 2022
@atc0005 atc0005 self-assigned this Aug 12, 2022
atc0005 added a commit that referenced this issue Aug 15, 2022
@atc0005
Downgrade golangci-lint from v1.48.0 to v1.47.3
4f81a00 
Downgrade golangci-lint to avoid Go 1.19 gofmt linting rules
from being applied when an earlier version of Go is used.

refs GH-699
@atc0005 atc0005 mentioned this issue Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working linting oldstable stable
Projects
None yet
Milestone
v0.6.22
Development

Successfully merging a pull request may close this issue.

Downgrade golangci-lint from v1.48.0 to v1.47.3 atc0005/go-ci
1 participant
@atc0005