Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override default user agent with project-specific value #203

Closed
atc0005 opened this issue Jan 31, 2022 · 2 comments · Fixed by #213
Closed

Override default user agent with project-specific value #203

atc0005 opened this issue Jan 31, 2022 · 2 comments · Fixed by #213
Assignees
@atc0005
Labels
config enhancement New feature or request
Milestone
v0.7.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Jan 31, 2022

Default user agent: Go-http-client/1.1.

Override with project-specific value similar to what the atc0005/check-vmware project is doing.

Something like: send2teams/v0.7.0
@atc0005 atc0005 added enhancement New feature or request config labels Jan 31, 2022
@atc0005 atc0005 added this to the Next Release milestone Jan 31, 2022
@atc0005 atc0005 self-assigned this Jan 31, 2022
@atc0005
Copy link
Owner Author

atc0005 commented Feb 7, 2022

Note to self: This might require updates to the atc0005/go-teams-notify project to implement.

@atc0005
Copy link
Owner Author

atc0005 commented Feb 7, 2022

See atc0005/go-teams-notify#134.

Implementing support there first will make this much easier to accomplish.

atc0005 added a commit that referenced this issue Feb 9, 2022
@atc0005
Override default user agent
8d71a16 
Use new SetUserAgent() API method from atc0005/go-teams-notify
project to override the default Go user agent when submitting
messages.

refs GH-203
@atc0005 atc0005 mentioned this issue Feb 9, 2022
Merged
atc0005 added a commit that referenced this issue Feb 9, 2022
@atc0005
Override default user agent
785fb70 
Use new SetUserAgent() API method from atc0005/go-teams-notify
project to override the default Go user agent when submitting
messages.

refs GH-203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
config enhancement New feature or request
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Override default user agent atc0005/send2teams
1 participant
@atc0005