Intermittent message submission failure when using --user-mention flag
#225
Comments
|
Ran into this when testing a maintenance script that pings me after each long running step completes. Out of the four expected notifications, 1 continually fails and 3 succeed. Not sure if it's a timing issue or if the barely supported "botapi" format provided by the atc0005/go-teams-notify project will continue to have this problem. |
Just had it fail 2 out of the 4 times. |
|
In contrast, not using the |
atc0005
changed the title
--user-mention flag--user-mention flag
|
Now that the work on atc0005/go-teams-notify#157 has sufficiently progressed, I'm working on a fix for this GH issue. Hoping to cut a new release for this project within the next week (or so). |
Note: Most of the "temporary" restrictions of using user mentions support and losing out on other support looks like it will persist:
The |
|
Note: Testing/research shows that the Will likely need to reject use of that if used alongside the |
|
Beginning testing against existing environments that rely on MessageCard support. Considering dropping support for that format. |
Going in this direction. We can bring back support for generated MessageCard payloads later if requested. |
Opting to treat the flag as a NOOP, document as much in the README and in the help text. This should help ensure that the next release of this app is unlikely to break existing deployments. |
Add early (and incomplete) implementation of `Adaptive Card` format (new `adaptivecard` package). This new package is an alternative to the current implementation of the legacy `MessageCard` format (`messagecard` package). Remove `botapi` package. This package was a partial implementation and intended as a temporary resource until the `adaptivecard` package was developed sufficiently to replace it. This package could make an appearance later in a more complete form if there is need for it. CHANGES The changes listed here are in comparison to the previous v2.7.0-alpha.1 release. - add initial implementation of the `adaptivecard` package - remove partial implementation of `botapi` package - incomplete implementation, known issues (atc0005/send2teams#225) - example code - create subdir for new `adaptivecard` examples and populate with equivalents - create subdir for existing `messagecard` examples - refresh doc comments of existing examples - attempt to simplify implementation of examples - documentation refresh - cover new features provided by the new `adaptivecard` package - make note of plans to extend v2 branch features while retaining backwards compatibility with an eye towards a future v3 series - add `goteamsnotify.InList()` helper func - simplify `goteamsnotify.messagePreparer` interface - simplify `MessageCard.Prepare()` implementation - explicitly mark files containing exclusively deprecated code - explicitly mark existing formatting functionality as specific to the `MessageCard` format LIMITATIONS - the `adaptivecard` package is new and its API is subject to change before the next stable release - the `adaptivecard` package is incomplete - while the new package contains sufficient functionality to be useful and provide a close approximation of functionality to the existing `messagecard` package, it is still missing support for some (available) features that the older package provides - there are many TODO items for the new `adaptivecard` package, most of which are intended to be removed before the next stable release - there are active `gocognit` linter warnings for the `Validate()` method for multiple types in the new `adaptivecard` package - this method is responsible for asserting known requirements for multiple field values for its type - more "bake time" is needed to determine a simpler approach REFERENCES - refs GH-157 - refs atc0005/send2teams#225
OVERVIEW
Resolve intermittent user mention submission failure by swapping out
the `botapi` implementation of user mention support for the new
`adaptivecard` package. This new package generates payloads with user
mentions that fully comply with published Microsoft Teams requirements.
Temporary restrictions applied in the last release between user
mentions and the URL "buttons", title flags have been removed.
This app now exclusively uses the `adaptivecard` package.
Unfortunately, the `Adaptive Card` format does not (at the time of
this writing) support message color theming (border trim color). This
flag now is a NOOP; while using this flag does not produce an error,
it no longer does anything.
CHANGES
- replace `botapi` and `messagecard` packages with `adaptivecard`
package
- exclusively use `adaptivecard` package to generate Microsoft Teams
messages
- add missing checks for use of `--silent` flag before emitting
warning/error output
- resolve intermittent user mention submission failure
- the `--target-url` flag no longer enforces a set limit of 4 URL
"buttons"
- documentation
- the current Microsoft Teams message size limit of
*approximately* 28 KB is explicitly noted
- references to the `references to the `--color` flag have been
removed (aside from the explicit NOOP behavior in the config
flag table)
- mention that the generated JSON payload is now emitted in
verbose ouput (exposed via the `--verbose` flag)
REFERENCES
- refs GH-225
- refs atc0005/go-teams-notify#162
OVERVIEW
Resolve intermittent user mention submission failure by swapping out
the `botapi` implementation of user mention support for the new
`adaptivecard` package. This new package generates payloads with user
mentions that fully comply with published Microsoft Teams requirements.
Temporary restrictions applied in the last release between user
mentions and the URL "buttons", title flags have been removed.
This app now exclusively uses the `adaptivecard` package.
Unfortunately, the `Adaptive Card` format does not (at the time of
this writing) support message color theming (border trim color). This
flag now is a NOOP; while using this flag does not produce an error,
it no longer does anything.
CHANGES
- replace `botapi` and `messagecard` packages with `adaptivecard`
package
- exclusively use `adaptivecard` package to generate Microsoft Teams
messages
- add missing checks for use of `--silent` flag before emitting
warning/error output
- resolve intermittent user mention submission failure
- the `--target-url` flag no longer enforces a set limit of 4 URL
"buttons"
- documentation
- the current Microsoft Teams message size limit of
*approximately* 28 KB is explicitly noted
- references to the `references to the `--color` flag have been
removed (aside from the explicit NOOP behavior in the config
flag table)
- mention that the generated JSON payload is now emitted in
verbose ouput (exposed via the `--verbose` flag)
REFERENCES
- refs GH-225
- refs atc0005/go-teams-notify#162
OVERVIEW
Resolve intermittent user mention submission failure by swapping out
the `botapi` implementation of user mention support for the new
`adaptivecard` package. This new package generates payloads with user
mentions that fully comply with published Microsoft Teams requirements.
Temporary restrictions applied in the last release between user
mentions and the URL "buttons", title flags have been removed.
This app now exclusively uses the `adaptivecard` package.
Unfortunately, the `Adaptive Card` format does not (at the time of
this writing) support message color theming (border trim color). This
flag now is a NOOP; while using this flag does not produce an error,
it no longer does anything.
CHANGES
- replace `botapi` and `messagecard` packages with `adaptivecard`
package
- exclusively use `adaptivecard` package to generate Microsoft Teams
messages
- add missing checks for use of `--silent` flag before emitting
warning/error output
- resolve intermittent user mention submission failure
- the `--target-url` flag no longer enforces a set limit of 4 URL
"buttons"
- documentation
- the current Microsoft Teams message size limit of
*approximately* 28 KB is explicitly noted
- references to the `--color` flag have been removed (aside
from the explicit NOOP behavior in the config flag table)
- mention that the generated JSON payload is now emitted in
verbose ouput (exposed via the `--verbose` flag)
REFERENCES
- refs GH-225
- refs atc0005/go-teams-notify#162
OVERVIEW
Resolve intermittent user mention submission failure by swapping out
the `botapi` implementation of user mention support for the new
`adaptivecard` package. This new package generates payloads with user
mentions that fully comply with published Microsoft Teams requirements.
Temporary restrictions applied in the last release between user
mentions and the URL "buttons", title flags have been removed.
This app now exclusively uses the `adaptivecard` package.
Unfortunately, the `Adaptive Card` format does not (at the time of
this writing) support message color theming (border trim color). This
flag now is a NOOP; while using this flag does not produce an error,
it no longer does anything.
CHANGES
- replace `botapi` and `messagecard` packages with `adaptivecard`
package
- exclusively use `adaptivecard` package to generate Microsoft Teams
messages
- add missing checks for use of `--silent` flag before emitting
warning/error output
- resolve intermittent user mention submission failure
- the `--target-url` flag no longer enforces a set limit of 4 URL
"buttons"
- documentation
- the current Microsoft Teams message size limit of
*approximately* 28 KB is explicitly noted
- references to the `--color` flag have been removed (aside
from the explicit NOOP behavior in the config flag table)
- mention that the generated JSON payload is now emitted in
verbose ouput (exposed via the `--verbose` flag)
REFERENCES
- refs GH-225
- refs atc0005/go-teams-notify#162
|
Resolved per GH-228. |
Output:
When I use the
--verboseflag I can see that the JSON payload has a message, but still the messages persists.The text was updated successfully, but these errors were encountered: