Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smacker crashes apps that reject multiple times in Promise.all #9

Open
hypesystem opened this issue Mar 26, 2024 · 1 comment
Open

smacker crashes apps that reject multiple times in Promise.all #9

hypesystem opened this issue Mar 26, 2024 · 1 comment

Comments

@hypesystem
Copy link

hypesystem commented Mar 26, 2024 •
edited

C.f. this discussion nodejs/node#24321 - multipleResolves may be triggered if Promise.all or Promise.race receives multiple rejections. This is fully valid and normal behavior, but smacker reads it as a problem and crashes the application.

I don't know if there is a way to detect this particular case.
@hypesystem
Copy link
Author

multipleResolves is actually deprecated: nodejs/node#41872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hypesystem