Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply dark-mode unless the page is using its own dark mode #3340

Open
unixbhaskar opened this issue Feb 12, 2024 · 2 comments
Open

Apply dark-mode unless the page is using its own dark mode #3340

unixbhaskar opened this issue Feb 12, 2024 · 2 comments
Labels
feature Feature requests.

Comments

@unixbhaskar
Copy link

Describe the bug
Say, I have dark mode enabled for Reddit and LInkedIN, Now if I try to open those page, it malformed and lost it color and representation.
Precise recipe to reproduce the issue
Just open the darkened version and use dark mode again on those.

For website-specific issues:
Can you reproduce this issue with Epiphany / GNOME Web (https://wiki.gnome.org/Apps/Web)?
No other browser showing this : Vimb, firefox
Information

  • OS name+version: Gentoo, Slackware, Debian (latest)
  • Graphics card and driver: Mesa
  • Desktop environment / Window manager name+version: i3 window manager (barebone, No DE)
  • How you installed Nyxt (Guix pack, package manager, build from source): Compiled from Source
  • Information from show-system-information:
    bhaskar_13:54:14_Mon Feb 12: :~>nyxt --system-information
    Nyxt version: 3.11.2
    Renderer: GI-GTK
    Operating system kernel: Linux 6.7.1-gentoo-dist
    Lisp implementation: SBCL 2.3.5 (Dynamic space size: 3221225472)
    Features: (:NYXT-GI-GTK :NYXT-GTK :NYXT-GI-GTK :NYXT-GTK :NYXT-3.11 :NYXT-3 :NYXT-3.11.2
    :CLIPBOARD-CONTENT-METHOD :SWANK :SLYNK :PLUMP-UTF-32 :PARENSCRIPT :NSYMBOLS
    :FSET-EXT-STRINGS :SBCL+SAFE-STANDARD-READTABLE :NAMED-READTABLES :GLOBAL-VARS
    :CL-FAD :LPARALLEL :21BIT-CHARS :CUSTOM-HASH-TABLE-NATIVE :CL-PPCRE-UNICODE
    :CL-UNICODE :CL-JSON-DOUBLE-FLOAT-IS-SUBSUMED
    :CL-JSON-SINGLE-FLOAT-IS-SUBSUMED :CHUNGA :FLEXI-STREAMS :CL-PPCRE :WEBKIT2
    :WEBKIT-2.42.1 :WEBKIT-2.42 :WEBKIT-2 :WEBKIT2-CORS-ALLOWLIST
    :WEBKIT2-PASTE-PLAINTEXT :WEBKIT2-TRACKING :WEBKIT2-MUTE :WEBKIT2-EMOJI
    :WEBKIT2-MEDIA :WEBKIT2-SANDBOXING :GTK-3-22 :GTK-3-20 :GTK-3-18 :GTK-3-16
    :GTK-3-14 :GTK-3-12 :GTK-3-10 :GTK-3-8 :GTK-3-6 :GTK-3-4 :GTK :GDK-3-22
    :GDK-3-20 :GDK-3-18 :GDK-3-16 :GDK-3-14 :GDK-3-12 :GDK-3-10 :GDK-3-8 :GDK-3-6
    :GDK-3-4 :CAIRO-1-10 :CAIRO-1-12 :GDK-PIXBUF :CLOSER-MOP :GLIB-2-30 :GLIB-2-32
    :GLIB-2-34 :GLIB-2-36 :GLIB-2-38 :GLIB-2-40 :GLIB-2-42 :GLIB-2-44 :GLIB-2-46
    :GLIB-2-48 :GLIB-2-50 :GLIB-2-52 :GLIB-2-54 :GLIB-2-56 :GLIB-2-58 :GLIB
    :BORDEAUX-THREADS :LPARALLEL.WITH-CLTL2 :LPARALLEL.WITH-CAS
    :LPARALLEL.WITH-STEALING-SCHEDULER :SPLIT-SEQUENCE
    CFFI-FEATURES:FLAT-NAMESPACE CFFI-FEATURES:X86-64 CFFI-FEATURES:UNIX :CFFI
    CFFI-SYS::FLAT-NAMESPACE ALEXANDRIA::SEQUENCE-EMPTYP :FAST-IO-SV :FAST-IO
    :CL-JSON-CLOS :CL-JSON :SBCL-USES-SB-ROTATE-BYTE CHIPZ-SYSTEM:GRAY-STREAMS
    :THREAD-SUPPORT :ASDF3.3 :ASDF3.2 :ASDF3.1 :ASDF3 :ASDF2 :ASDF :OS-UNIX
    :NON-BASE-CHARS-EXIST-P :ASDF-UNICODE :ARENA-ALLOCATOR :X86-64 :GENCGC :64-BIT
    :ANSI-CL :COMMON-LISP :ELF :IEEE-FLOATING-POINT :LINUX :LITTLE-ENDIAN
    :PACKAGE-LOCAL-NICKNAMES :SB-CORE-COMPRESSION :SB-LDB :SB-PACKAGE-LOCKS
    :SB-THREAD :SB-UNICODE :SBCL :UNIX)

ASDF version: 3.3.5
ASDF registries: (NYXT-SOURCE-REGISTRY ENVIRONMENT-SOURCE-REGISTRY)
Critical dependencies: (/home/bhaskar/Downloads/nyxt-3.11/_build/cl-cffi-gtk/gtk/cl-cffi-gtk.asd
/home/bhaskar/Downloads/nyxt-3.11/_build/cl-gobject-introspection/cl-gobject-introspection.asd
/home/bhaskar/Downloads/nyxt-3.11/_build/cl-webkit/webkit2/cl-webkit2.asd)

If you can't run show-system-information, try nyxt --system-information from
a shell. It this still does not work, please provide the following:

  • Nyxt version (from the nyxt-version command or nyxt --version from a shell):
  • Lisp implementation/version (if built from source):
  • Kernel name+version: 6.7.1
  • WebKitGTK+ | QtWebEngine version:

Output when started from a shell

@aadcg aadcg added the feature Feature requests. label Feb 12, 2024
@aadcg aadcg changed the title Already darken page in web ,lack proper representation in dark mode. Can Nyxt sense, that the page is already darkened and not apply dark mode?? Apply dark-mode unless the page is using its own dark mode Feb 12, 2024
@aadcg
Copy link
Member

aadcg commented Feb 12, 2024

The check could be made via JS.

Also, dark-mode could be enabled on URLs matching a certain predicate via auto-rules. Visit nyxt:manual#auto-rules from Nyxt.

@unixbhaskar
Copy link
Author

The check could be made via JS.

Also, dark-mode could be enabled on URLs matching a certain predicate via auto-rules. Visit nyxt:manual#auto-rules from Nyxt.

Gotcha!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests.
Development

No branches or pull requests

2 participants