Bug - shadow variable clash with destructured props #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshmalde
requested review from
MonicaOlejniczak,
JakeLane,
at-nathan,
blackheart-atlassian,
pancaspe87,
TimeRaider,
heliam1,
hannahkmolloy and
csowden-atlassian
as code owners
🦋 Changeset detectedLatest commit: ccefa7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pancaspe87
reviewed
Apr 12, 2022
|
@harshmalde run |
…nto bug/shadowed-var-clash-with-destructured-props
pancaspe87
reviewed
Apr 21, 2022
pancaspe87
requested changes
Apr 21, 2022
There was a problem hiding this comment.
There is still a VR fail to address.
FAIL chrome.docker/chrome.laptop/conditional rules/styled/Condition With Destructured Props Key Value String: Failed to render with error "primary is not defined"
This is caused by a story within stories/conditional-rules-styled.tsx
The fix doesn't seem to take into account cases such as
const DestructuredPropsKeyValueString = styled.div<TextProps>`
${({ isPrimary: primary }) => (primary ? 'color: green' : 'color: red')};
`;
added 3 commits
April 22, 2022 11:03
…nto bug/shadowed-var-clash-with-destructured-props
pancaspe87
reviewed
Apr 28, 2022
pancaspe87
previously approved these changes
Apr 28, 2022
JakeLane
requested changes
Apr 28, 2022
JakeLane
approved these changes
May 9, 2022
pancaspe87
approved these changes
May 9, 2022
Merged
at-nathan
added a commit
that referenced
this pull request
Jul 13, 2022
This reverts commit 4f8f2aa.
at-nathan
added a commit
that referenced
this pull request
Jul 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
When shadow variable name and deconstructed
propsproperty are same, babel is unable to differentiate between them (since both the property will be of typeIdentifierand you can have a look at the storybook that has been created with this PR).Implementation:
This pull request helps to reconstruct the destructed props in the Arrow function.