Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme security improvement: Split up npm and yarn code blocks #178

Open
plocket opened this issue Nov 26, 2023 · 1 comment · May be fixed by #179
Open

Readme security improvement: Split up npm and yarn code blocks #178

plocket opened this issue Nov 26, 2023 · 1 comment · May be fixed by #179

Comments

@plocket
Copy link

plocket commented Nov 26, 2023

Currently, the README has

$ npm i better-ajv-errors
$ # Or
$ yarn add better-ajv-errors

One problem with this is that it doesn't allow the developer to just hit 'copy' and paste it into their terminal. npm has problems with people "typo squatting", so copy/pasting is a safer and more secure option than re-typing by hand. Separate code blocks for each command would let a developer stay safer.

plocket added a commit to plocket/better-ajv-errors that referenced this issue Nov 27, 2023
Close atlassian#178. Allows developer to just copy/paste, which avoids the danger from typo squatting.
@plocket plocket linked a pull request Nov 27, 2023 that will close this issue
@plocket
Copy link
Author

plocket commented Nov 27, 2023

I made a PR, but can't follow through because the form asks for PI I'm not willing to give. It's pretty straightforward, though, if someone else wants to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant