Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct way to control version? #80

Open
phuo1032 opened this issue Apr 26, 2017 · 3 comments
Open

Correct way to control version? #80

phuo1032 opened this issue Apr 26, 2017 · 3 comments

Comments

@phuo1032
Copy link

phuo1032 commented Apr 26, 2017

Hi,

What's the right way to update the major, minor or patch version correctly. No matter which type I selected (fix, feat, docs), I always ended up with a major version when running "lerna-semantic-release pre"

info:    Executing pre in packages/[my-package-name]
info:    Anaylzed 4 / 65 commits to determine type major for [my-npm-artifact]
info:    Relevant commits:
*  347788f0499dd6d099ec7bed41e58ad1c0b0e324
* 2c8f9802205e7a6891e5321e7189e17e58ac6266
* 1ad3d34c31450d16c91652fa6f4c50420d372ae2
* f4ea3d50cf0dc26ae0064a70ba1f4f1b66c9859c
info:    Executing bumpVersionCommitAndTag in packages/[my-package-name]
info:     type=initial, version=1.0.0
info:    Creating tag [my-npm-artifact]@1.0.0
[my package directory]
[my git repo dirertory]
info:    + npm version major --git-tag-version false
v3.0.0
info:    out > v3.0.0

info:    + git commit -anm'chore(release): releasing component

And if I repeat "lerna-semantic-release pre" a couple time, it'll just keep bumping the major version over and over. So I may be ending up with v7.0.0 from v2 if I run the script 5 times.

Am I doing this wrong?

@bradbarrow
Copy link

We're having the exact same issue, any luck fixing this @phuo1032 ?

Thanks in advance

@phuo1032
Copy link
Author

@bradbarrow, I forgot about the ticket myself. Yes, I did find out why. We are using private artifactory. Therefore, the default setup is never able to determine the current released version or hash. I forked this repo and modify the code that determines these data.

@amurdock
Copy link

amurdock commented Sep 6, 2017

@bradbarrow I think this pr sorts the issue you're experiencing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants