Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NPM-standard publishConfig instead of config to define access level #81

Open
jan-molak opened this issue May 23, 2017 · 1 comment

Comments

@jan-molak
Copy link

Hi there!

NPM has a standard way of configuring the scoped package's access level and deployment registry.
This is done using the publishConfig key in the package.json, as per the docs.

However, instead of using the publishConfig, lerna-semantic-release relies on the config key instead. This means that even though the publishConfig.access property is specified, lerna-semantic-release ignores it and publishes any scoped package as private.

It would be great if lerna-semantic-release could use the same NPM standard as it would make releasing scoped packages easier.

@junosuarez
Copy link

likewise, in lerna-semantic-release-get-last-release, rather than checking for private:true, if publishConfig.registry is set, I think it should use the local version registration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants