Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): add lerna 3.0.0 support #95

Closed
wants to merge 1 commit into from

Conversation

silouanwright
Copy link

@silouanwright silouanwright commented Mar 2, 2019

affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: #93

Note: Some of the node configuration needed to be changed to properly build.

@silouanwright
Copy link
Author

Please let me know if there are any changes I can make to improve upon this PR (commit message, semantic release format, etc).

@silouanwright silouanwright force-pushed the caribou branch 7 times, most recently from c58428f to f299a02 Compare March 2, 2019 03:48
affects: lerna-semantic-release-io, lerna-semantic-release-utils

ISSUES CLOSED: atlassian#93
@shogochiai
Copy link

shogochiai commented Apr 16, 2019

Note for people who tries this patch

It seems node_module/.bin doesn't have lerna-semantic-release executable.
This might be because I'm using git-url install (I guess I can use that after this patch being merged and published)

You'll see command executable at node_modules/lerna-semantic-release/packages/lerna-semantic-release/bin/lerna-semantic-release.js

@lukebatchelor
Copy link
Member

@shogochiai that's expected. Monorepos wont let you install from git as there's no single package.json to be read to know what to link.

You can close the repo and checkout this branch to build and link if you'd like, or publish it under a different namespace. Both would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lerna@3.0.0 support
4 participants