Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise repo with commit messages (eg. --fast-forward) #20

Open
sergioisidoro opened this issue Apr 5, 2024 · 2 comments
Open

Synchronise repo with commit messages (eg. --fast-forward) #20

sergioisidoro opened this issue Apr 5, 2024 · 2 comments
Assignees

Comments

@sergioisidoro
Copy link

At the moment all commit messages are "Synchronise latest changes".

I'm super curious to try out this lib, but since it's also in an early stage, seeing what's changing / fixed is important. Seeing only opaque commit messages is a bit scary, as we don't know what's happening

I think Seeing the commit changes would be super helpful :)
Would it be possible to have the bot make fast forward merges when syncing?

SUPER curious to try this out. It looks like a lot of care and engineering effort was done here!

@danielweck
Copy link

I agree, the Git commit history matters to outsiders when assessing the project's qualities.
The Atlassian merges indeed look out of place.

Would it be possible to use "conventional commits" syntax for commit messages, as well as atomic "stash" for merge strategy in order to avoid scattered commit units in the chronological history?

@alexreardon
Copy link
Collaborator

Sharing commit messages over would be ideal 👌

Why we are not doing that right now:

  • we are technically not synchronising individual commits, rather, we are crushing all changes in a given time period for the pdnd related code into a single commit
  • The Pragmatic drag and drop code lives in a monorepo which contains private packages. We opted for an approach (for now) that would not leak any (potentially) private information. Commit messages could contain sensitive information that is not intended for public visibility.
  • A commit in the mono repo could span a number of packages (ie some public packages, and some private packages)

Is this problem solvable? Yes. But I wanted to give some context.

For now, you can see all the change information in our changelogs (flourish example)

Open to suggestions on how we could improve things, especially fairly low hanging options.

Perhaps one possibility for now is replicating our changelog information in Github releases, as Github releases allow you to see the code diff between versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants