Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Condition lastUpdateTime is not preserved #322

Closed
ash2k opened this issue Sep 25, 2018 · 1 comment
Closed

Condition lastUpdateTime is not preserved #322

ash2k opened this issue Sep 25, 2018 · 1 comment
Labels

Comments

@ash2k
Copy link
Contributor

ash2k commented Sep 25, 2018

Before Bundle condition transition:

{"type":"Ready","status":"False","lastUpdateTime":null, "lastTransitionTime":"2018-09-25T12:40:59Z"}

Transition happens, lastUpdateTime is filled:

{"type":"Ready","status":"True", "lastUpdateTime":"2018-09-25T12:41:01Z","lastTransitionTime":"2018-09-25T12:41:01Z"}

After next reconciliation it is lost:

{"type":"Ready","status":"True", "lastUpdateTime":null, "lastTransitionTime":"2018-09-25T12:41:01Z"}

This is true for both Bundle's conditions and for resource's conditions.

@ash2k ash2k added the bug label Sep 25, 2018
@ash2k
Copy link
Contributor Author

ash2k commented Sep 26, 2018

Looks like all kube api types except for Deployment got rid of last update time (or never had it) in their conditions. See kubernetes/kubernetes#55268 (comment) and kubernetes/kubernetes#55272 (comment).
So the fix here would be to remove it to simplify it all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant