Separators are nearly invisible with One Dark and One Light

[gilbertohasnofb]

Separators are nearly invisible with One Dark and One Light:

But work fine with virtually all other UI themes:

[gilbertohasnofb]

Perhaps an idea of how to solve this would be to use full white and full black colours with added alpha to the separator top/down and left/right sides. The alpha should take care to make it adapt to any background colour.

[suda]

I played around with mix-blend-mode to make the separator always brighter than the background. screen mode does work but it doesn't look nice IMO:

I think the best way is to add an override in the theme-one-dark-ui.less and create one for any other theme that might need it.

@simurai do you have any thoughts on this perhaps?

[gilbertohasnofb]

Thank you for taking a look at this.

but it doesn't look nice IMO

That PR I had initially opened had virtually the same exact results, which is why I closed it; it's definitely better than the current One Dark and One Light result, but it makes all other UI themes look worse, transforming their separators into a single bright line without shadow.

I think the best way is to add an override in the theme-one-dark-ui.less and create one for any other theme that might need it.

I think that would be a good solution. From my tests, One Dark and One Light are the only ones showing this problem so having an override for them make sense.