Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: atom-community/eslint-config-atomic
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.19.0
Choose a base ref
...
head repository: atom-community/eslint-config-atomic
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.19.1
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on May 24, 2023

  1. fix: remove no-parameter-properties

    @aminya
    aminya committed May 24, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    a411ac4 View commit details

  2. Merge pull request #71 from atom-community/no-parameters-properties [… 

    …skip ci]
    @aminya
    aminya authored May 24, 2023
    Copy the full SHA
    cdde65b View commit details

  3. chore: v1.19.1

    @aminya
    aminya committed May 24, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    ddf11f8 View commit details
Showing with 1 addition and 2 deletions.
  1. +1 −1 package.json
  2. +0 −1 src/typescript.js
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-atomic",
"version": "1.19.0",
"version": "1.19.1",
"description": "Eslint config used in atom-ide-community",
"repository": "https://github.com/atom-ide-community/eslint-config-atomic",
"license": "MIT",
1 change: 0 additions & 1 deletion src/typescript.js
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,6 @@ const pluginTypeScriptRulesExtra = {
"@typescript-eslint/no-shadow": "error",
"@typescript-eslint/no-dynamic-delete": "error",
"@typescript-eslint/no-extraneous-class": "error",
"@typescript-eslint/no-parameter-properties": "error",
// "@typescript-eslint/no-unnecessary-type-arguments": "error",
"@typescript-eslint/no-unnecessary-type-constraint": "error",
// "@typescript-eslint/prefer-function-type": "error",