Failed installs of tree-sitter grammar packages on Windows

[tmatijevich]

Description

apm fails to install tree-sitter grammar packages on Windows.

Steps to Reproduce

1. apm install language-hclrs or apm install language-tree-test or any community tree-sitter grammar

Expected behavior:

Installs the grammar package and dependencies.

Actual behavior:

$ apm install language-hclrs
Installing language-hclrs to C:\Users\b\.atom\packages failed

> tree-sitter-hclrs@0.0.2 install C:\Users\b~1\AppData\Local\Temp\apm-install-dir-202161-13744-rsb1j6.d6fhi\node_modules\language-hclrs\node_modules\tree-sitter-hclrs
> node-gyp rebuild


C:\Users\b~1\AppData\Local\Temp\apm-install-dir-202161-13744-rsb1j6.d6fhi\node_modules\language-hclrs\node_modules\tree-sitter-hclrs>if not defined npm_config_node_gyp (node "C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )

gyp ERR! find VS
gyp ERR! find VS msvs_version not set from command line or npm config
gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:372:16
gyp ERR! stack     at C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Users\b\AppData\Local\atom\app-1.56.0\resources\app\apm\node_modules\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:297:5)
gyp ERR! stack     at ChildProcess.emit (events.js:200:13)
gyp ERR! stack     at maybeClose (internal/child_process.js:1021:16)
gyp ERR! System Windows_NT 10.0.19042
gyp ERR! command "C:\\Users\\b\\AppData\\Local\\atom\\app-1.56.0\\resources\\app\\apm\\bin\\node.exe" "C:\\Users\\b\\AppData\\Local\\atom\\app-1.56.0\\resources\\app\\apm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\b~1\AppData\Local\Temp\apm-install-dir-202161-13744-rsb1j6.d6fhi\node_modules\language-hclrs\node_modules\tree-sitter-hclrs
gyp ERR! node -v v12.4.0
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm WARN enoent ENOENT: no such file or directory, open 'C:\Users\b~1\AppData\Local\Temp\apm-install-dir-202161-13744-rsb1j6.d6fhi\package.json'
npm WARN apm-install-dir-202161-13744-rsb1j6.d6fhi No description
npm WARN apm-install-dir-202161-13744-rsb1j6.d6fhi No repository field.
npm WARN apm-install-dir-202161-13744-rsb1j6.d6fhi No README data
npm WARN apm-install-dir-202161-13744-rsb1j6.d6fhi No license field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! tree-sitter-hclrs@0.0.2 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the tree-sitter-hclrs@0.0.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\b\.atom\.apm\_logs\2021-07-01T18_56_23_075Z-debug.log

Reproduces how often:

100% on community tree-sitter packages on Windows.

Versions

> apm --version

apm  2.5.2
npm  6.14.8
node 12.4.0 x64
atom 1.56.0
python 3.9.3
git 2.30.0.windows.2
visual studio

Additional Information

Do Windows users need the windows build tools (required for node-gyp builds) in order to install tree-sitter-abc node packages?
This does not seem to be a problem with (pre-built?) core packages.

• atom issue
• hclrs issue
• tree test issue