Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Opening a second Select List reverts focus to editor #6

Open
1 task done
CadenP opened this issue Apr 11, 2017 · 1 comment
Open
1 task done

Opening a second Select List reverts focus to editor #6

CadenP opened this issue Apr 11, 2017 · 1 comment
Labels

Comments

@CadenP
Copy link

CadenP commented Apr 11, 2017

Prerequisites

Description

Opening a second Select List on top of another results in the Select List being unfocused, and reverts focus to the editor.

Steps to Reproduce

  1. Open Fuzzy Finder
  2. Open Command Palette without closing the Fuzzy Finder

Expected behavior:
Command Palette is focused - typing results in text in field.

Actual behavior:
Command Palette is not focused - typing does not result in text in field.
Typing results in text on currently opened file.

Reproduces how often:
100% reproduce rate from a small number of tests.

Versions

macOS 10.11.5

Atom : 1.16.0-beta0
Electron: 1.3.13
Chrome : 52.0.2743.82
Node : 6.5.0

apm 1.16.1
npm 3.10.5
node 6.9.5 x64
python 2.7.10
git 2.10.1

@Pazzaz
Copy link

Pazzaz commented Aug 1, 2017

The problem is that the command palette focuses itself, then fuzzy finder (reacting to loosing focus) gives focus to whatever had focus before it was opened. In your example, this happened to be the editor. I believe this can be fixed in the respective packages by having them check for an instance of atom-select-list before calling .focus().

Edit: well not for an instance, just if there is a visible instance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants