no sudo in terminals created with child_process.spawn

[moritzschepp]

Prerequisites

• Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
• Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
• Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
• Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
• Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Subprocesses created with child_process.spawn can't use sudo. The problem was also described in #6702 and it was suggested that it was solved. I'm seeing this with atom 1.47.0 x64, though.

Steps to Reproduce

Drop this in your init.coffee:

spawn = require('child_process').spawn
spawn('mate-terminal', [], {detached: true})

and reload the atom window.

Expected behavior:

The resulting terminal window should allow to use sudo.

Actual behavior:

Trying to use sudo returns:

sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?

Reproduces how often:

100%

Versions

Atom : 1.47.0
Electron: 5.0.13
Chrome : 73.0.3683.121
Node : 12.0.0

Additional Information

Its worth noting that the problem doesn't occur with gnome-terminal, although I believe that's because it connects to a gnome-terminal-server which is not started as a child process.

Perhaps related: electron/electron#18521

Let me know if I can provide more information.

[the-j0k3r]

See electron/electron#23881 this is an electron 5-0-x regression, worked with Atom 1.46.x and electron 4.2.7

I submitted a pr for the backport to electron 5-0-x branch which is what Atom 1.47.x uses

Resolution for now, Downgrade to Atom 1.46.x with electron 4.2.7

Also related to https://github.com/bus-stop/terminus/issues/84

[moritzschepp]

Thanks for looking into this!

A workaround is also the gnome-terminal, if available.

[the-j0k3r]

Well 5.0.x electron is no longer supported so only electron 6.0.x or 7.0,x

See electron/electron#23881 (comment)

[the-j0k3r]

Now that #21079 (comment) is merged this issue will be fixed by a Atom release with electron 6.x