New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: test docker build before deploying #606

Open

joepio opened this issue Mar 2, 2023 · 0 comments · May be fixed by #621

Member

joepio commented Mar 2, 2023

We do end-to-end tests in the CI, but the dockerfile generation is actually performed as a separate action.

What can we do to improve this?

Run the docker job after all other steps from main using the needs keyword. However, this still allows issues with the docker image itself (e.g. missing a port forward, or some compatibility issue with the image). Also, it might run too often this way.
In the docker job, run the e2e tests after building the image, but before pushing it. This requires some changes, because currently one action does both the pushing and the building.

The text was updated successfully, but these errors were encountered:

joepio added a commit that referenced this issue


          #606 run docker image in CI

973c6e0

joepio linked a pull request

that will close this issue

Add tests for docker image #621

Draft

5 tasks

joepio added a commit that referenced this issue


          #606 run docker image in CI

15465d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment