Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-renew TLS requires reboot, takes too long #860

Open
joepio opened this issue Mar 12, 2024 · 2 comments
Open

Auto-renew TLS requires reboot, takes too long #860

joepio opened this issue Mar 12, 2024 · 2 comments

Comments

@joepio
Copy link
Member

joepio commented Mar 12, 2024

atomicdata.dev was just down, because the TLS / HTTPS cert was outdated.

I suppose the https check should have some buffer (e.g. one week before being outdated). Also, maybe it should check at runtime and reboot? Not sure.

@pinkforest
Copy link

pinkforest commented Apr 24, 2024

Maybe Automatic Certificate Management Environment (ACME) integration would be feasible ?

EDIT: ah yes it's already there https://github.com/atomicdata-dev/atomic-server/blob/develop/server/src/https.rs#L173

Just needs runtime timer without wasting a thread to it in runtime - e.g. using interval / ticks

Probably on serve.rs there is plug for re-starting the server context by first pulling server.handle().stop(..)

@joepio
Copy link
Member Author

joepio commented Apr 25, 2024

Just needs runtime timer without wasting a thread to it in runtime - e.g. using interval / ticks

Clever! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants