Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert JS Array to multiple Glob matching pattern #15

Merged
merged 1 commit into from Oct 7, 2022
Merged

fix: convert JS Array to multiple Glob matching pattern #15

merged 1 commit into from Oct 7, 2022

Conversation

mochazzxx
Copy link
Contributor

@mochazzxx mochazzxx commented Oct 6, 2022 •
edited

glob has differnet matching patterns than globby.

isaacs/node-glob#217

@atomicpages
Copy link
Owner

Nice, good catch! Thanks for the contrib 🙏

@atomicpages atomicpages merged commit ce64361 into atomicpages:main Oct 7, 2022
@mochazzxx mochazzxx deleted the support-src-array-patterns branch October 7, 2022 21:04
@pbeshai
Copy link

pbeshai commented Nov 23, 2022 •
edited

Would you mind publishing this fix please?

@atomicpages
Copy link
Owner

@pbeshai + @mochazzxx, published! I didn't see the workflow failed 😬

@pbeshai
Copy link

pbeshai commented Nov 25, 2022

No worries, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomicpages atomicpages atomicpages approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mochazzxx @atomicpages @pbeshai