Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the editor background color #5

Closed
donatoaguirre24 opened this issue Jun 2, 2019 · 6 comments
Closed

Issue with the editor background color #5

donatoaguirre24 opened this issue Jun 2, 2019 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@donatoaguirre24
Copy link

Hi, first of all, congratulations, the theme looks really awesome and the color composition it's very well achieved.

The only issue I found is a weird behavior with the background of the editor. It's shown a darker rectangle at the right side, in almost every file that I opened.

I gonna attach a screenshot for illustration purposes.

image

@atomiks
Copy link
Owner

atomiks commented Jun 3, 2019

Ughh yes I noticed that too with the new Electron color profile upgrade in February. I don't know why it occurs... since it's not noticeable on the default theme for example.

I've been staying on 1.30.2 which has much more vibrant colors and doesn't have that problem. microsoft/vscode#68001 (comment)

If there's a fix for it for the new versions please make a PR!

@atomiks atomiks added bug Something isn't working help wanted Extra attention is needed labels Jun 3, 2019
@atomiks
Copy link
Owner

atomiks commented Jun 8, 2019

microsoft/vscode#48043

I found this issue. It seems they fixed it a year ago but the February update caused problems again, but it's fixed in Electron 4.x which should be out in the June release (early July I think?)

Not sure why there hasn't been a new issue on it though. Maybe because it's not very noticeable

@atomiks
Copy link
Owner

atomiks commented Jun 10, 2019

Okay so weirdly enough, only colors right around the editor.background color I chose for this theme causes the artifact problem. If you change any theme's background color to this theme's exact background color, the problem occurs.

For now, you can change editor.background to a different color. e.g. Palenight's "editor.background": "#292D3E"

It sucks because I tried my best to find the perfect background color, and that one is too light for me, and if I try to just move the color picker a few pixels from this theme's current background color, it's not enough to fix it. It's like a whole vicinity of colors around it that is buggy.

Anyway, as I said I'm pretty sure July 2019 release will fix this, so unfortunately we might need to wait.

@donatoaguirre24
Copy link
Author

I tried changing the color to the one that you put above and it fixed the problem. I agree with you that the current color of the background is the best one.

I gonna wait, hope that the July release will fix it. Thanks for your response and to take the time to research the issue.

@donatoaguirre24
Copy link
Author

I tried the exploration build of VS Code that uses Electron 4, and as you say the problem it's fixed 👍

@atomiks
Copy link
Owner

atomiks commented Jul 4, 2019

Fixed in latest stable it seems

@atomiks atomiks closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants