Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degraded performance in 4.2.6 vs 4.2.5 #340

Open
delucis opened this issue Nov 23, 2021 · 4 comments
Open

Degraded performance in 4.2.6 vs 4.2.5 #340

delucis opened this issue Nov 23, 2021 · 4 comments

Comments

@delucis
Copy link

delucis commented Nov 23, 2021

Hi, firstly, thanks for maintaining this excellent tool!

I’m seeing something that smells like a memory leak after upgrading to 4.2.6 from 4.2.5. I haven’t managed to figure it out yet, but over time, state changes that impact tooltip content appear to cause the browser to hang longer and longer with the profiler showing a long sequence of repeated Recalculate Style, Apply Style Changes records. (Hangs starting from 800ms after a couple of interactions, rapidly increasing to more than 8 seconds.)

This is in a complex app with a lot of tooltips sharing a singleton so I’ve not had much luck debugging further, but reverting to 4.2.5 resolved this, so I’m fairly sure 4.2.6 is the culprit. Will post more if I figure anything else out.

@atomiks
Copy link
Owner

atomiks commented Nov 23, 2021

mutableBox.children might not be getting cleaned up properly. (useSingleton.js)

https://github.com/atomiks/tippyjs-react/pull/334/files#diff-d20c88bd7c19ce3032fa6bcb0695c362d3a8d387700021626473ae988bda3082

@Jonnotie
Copy link

Any news on this? My NextJS application keeps hanging, only when Tippy is active. Usually after switching between a couple of pages.

@atomiks
Copy link
Owner

atomiks commented Feb 25, 2022

@Jonnotie are you using a singleton? 4.2.5 => 4.2.6 only changed one thing for singletons, if the earlier versions works I recommend downgrading to it for now. Otherwise take a look at the diff and try to revert/debug why it might be causing degraded perf. I don't have much time to work on Tippy anymore as I'm working on Floating UI which will be much better.

@scottbessler
Copy link

2.5 years later and I can confirm that this is definitely an issue. I recommend removing the 4.2.6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants