Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP requests still sending to server even if HTTP error is returned #213

Open
industral opened this issue Apr 17, 2019 · 0 comments · May be fixed by #214
Open

HTTP requests still sending to server even if HTTP error is returned #213

industral opened this issue Apr 17, 2019 · 0 comments · May be fixed by #214

Comments

@industral
Copy link
Contributor

Using AV.Player.fromURL with HTTP bad response, cause library to send requests till it satisfies condition @loop() unless @offset >= @length
https://github.com/audiocogs/aurora.js/blob/master/src/sources/browser/http.coffee#L57

Need to add code to handle such tries, and stop bombing server with requests.
industral added a commit to industral/aurora.js that referenced this issue Apr 17, 2019
@industral
fixed audiocogs#213
0a6c854 
added ability to pass custom chunkSize, instead of hardcoded 1MB
added package-lock.json
updated README
@industral industral linked a pull request Apr 17, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed #213 industral/aurora.js
1 participant
@industral