Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined IS_Ltables #23

Open
AlexanderOMara opened this issue Nov 12, 2016 · 2 comments
Open

undefined IS_Ltables #23

AlexanderOMara opened this issue Nov 12, 2016 · 2 comments

Comments

@AlexanderOMara
Copy link

AlexanderOMara commented Nov 12, 2016

Hey,

I tried using this plugin after installing it via NPM, but ran into some odd issues with the src/layer3.js file having some seemingly random typos throw in.

After debugging it, I determined one of the issues was MP3FrameHeader.FLAGS.tables.I_STEREO which should actually be MP3FrameHeader.FLAGS.I_STEREO. It seems this issue was fixed in the prior commit though, just the version on NPM is outdated for some reason.

Once I fixed that problem though, I ran into another very strange looking line of code.

var lsf_scale = IS_Ltables.SF_TABLE[right_ch.scalefac_compress & 0x1];

There is no IS_Ltables variable, and I think it is supposed to be:

var lsf_scale = tables.SF_TABLE[right_ch.scalefac_compress & 0x1];

This typo has not been fixed yet.

@JohnWeisz
Copy link

JohnWeisz commented Apr 7, 2019

Strangely, SF_TABLE appears to be a simple Float32Array, yet array members on lsf_scale are being accessed further down the code. Did you manage to find a solution to this @AlexanderOMara?

@JohnWeisz
Copy link

I think it's supposed to be this: https://github.com/fasterthanlime/jsmad/blob/master/src/layer3.js#L183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants