Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot of dependencies #7

Open
danigb opened this issue Sep 22, 2016 · 3 comments
Open

Lot of dependencies #7

danigb opened this issue Sep 22, 2016 · 3 comments

Comments

@danigb
Copy link
Collaborator

danigb commented Sep 22, 2016

Hi @dfcreative,

I've just tried to use the new audio-loader 0.6.0 and I took more than 10 seconds to install on my computer... And I don't think that's a good user experience, so I would love to solve it.

The only solution I can find is split this module in two: one for browser and other one for node, but I'm open to suggestions.

What do you think?

@dy
Copy link
Member

dy commented Sep 22, 2016

Hi @danigb. I guess you're right. It is difficult to maintain 2 versions of the same code though

@danigb
Copy link
Collaborator Author

danigb commented Sep 22, 2016

Hi,

I'm not thinking in maintain two version on the same code. For this I'm thinking in two options:

  1. Split the code in two modules. Something like audio-loader for browser, and audio-load for node that depends on the previous one and adds the node support (something like extracting the current index.jsfile). Or maybe three modules: to-audio-buffer to make the conversions, and two modules, one for browser and other for node.
  2. Release two npm packages using the same codebase.

@dy
Copy link
Member

dy commented Sep 22, 2016

I was planning to use audio-load for extending audio-loader to support streamed loading, like soundcloud streams. That could make audio work with streamed sources, what would be sweet.
So I can just make audio-load a node/etc wrapper for audio-loader, that would solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants