Add handling for lambda environment #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed because of dependencies. I think is time to bump the version of Node.js required 👍 Master is failing as well. |
|
Can this be merged @jfromaniello ? |
|
fixed in express-jwt@7.3.0. Sorry for the very very long delay... it's been 4 years 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Express and all Node.js frameworks auto normalize the headers but there is one environment which does not do it. AWS lambda does not normalize the headers. In order to normalize them usage of 3rd party library is needed. That's why I added the handling of
Authorizationheader.Please let me know whether the tests for that feature are necessary.