Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gettoken): Add callback capability in a backward compatibility fashion #249

Closed
wants to merge 6 commits into from

Conversation

skyless
Copy link

@skyless skyless commented Jan 24, 2021

Description

Making getToken asynchronous by adding an optional callback function, in a backward compatibility fashion.

References

#248

Testing

All 39 tests passing.

  • This change adds test coverage for changed functionality

Worth mentioning, I had to change the tests a little bit: all tests were sharing the same req and res objects while some tests are asynchronous. It means these objects use by one test would have been changed by the next test before it could verify it. Now every test has their own objects.

  • Fix indentation
  • Fix duplicated attribute
  • Fix unused variable

Checklist

  • I have added documentation for changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing

@skyless skyless force-pushed the feature/async-gettoken branch 3 times, most recently from a69f1da to 66197f3 Compare January 24, 2021 15:04
@jfromaniello
Copy link
Member

Thank you, in v7.1.0 you can use an async getToken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants