feat(gettoken): Add callback capability in a backward compatibility fashion #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making
getToken
asynchronous by adding an optional callback function, in a backward compatibility fashion.References
#248
Testing
All 39 tests passing.
Worth mentioning, I had to change the tests a little bit: all tests were sharing the same
req
andres
objects while some tests are asynchronous. It means these objects use by one test would have been changed by the next test before it could verify it. Now every test has their own objects.Checklist