#402: Don't fail if captureStackTrace is not a function #410
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziluvatar
reviewed
Sep 29, 2017
| Error.captureStackTrace(this, this.constructor); | ||
| if(Error.captureStackTrace) { | ||
| Error.captureStackTrace(this, this.constructor); | ||
| } |
There was a problem hiding this comment.
I'm curious, have you investigated why this happens in Chrome? (it uses the same v8 as node). Could you take a look? Maybe we can improve the Error creation without this if.
There was a problem hiding this comment.
From the issue:
I've started testing my application outside of Chrome and started receiving the error
So my understanding is that this function is specific to V8, meaning it works Chrome and node and not FF and Safari.
Here are some options:
- http://codegists.com/snippet/javascript/errorsjs_girvo_javascript for a slightly better in-code solution
- https://www.npmjs.com/package/error-polyfill for a heavier-weight browser-only polyfill
There was a problem hiding this comment.
:( I misread it, it's simpler your approach. I'll approve, I'll wait for merging to see if we have more fixes before I release a patch version (I mean currently).
ziluvatar
approved these changes
Oct 9, 2017
|
Released on v8.1.0. 🎉 Thanks @joovel !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.