Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to adjust issue instant to account for clock skew #42

Open
zachelrath opened this issue Mar 6, 2018 · 0 comments
Open

Add option to adjust issue instant to account for clock skew #42

zachelrath opened this issue Mar 6, 2018 · 0 comments

Comments

@zachelrath
Copy link

Clock skew in the assertion consumer can cause assertions created using node-saml to be invalidated due to the NotBefore SAML condition being in the future according to the assertion consumer's clock. The lifetimeInSeconds option accounts for some clock skew in one direction, but does not account for the assertion consumer's clock being ahead of the assertion producer.

I have encountered this issue trying to use node-saml to create assertions for consumption by Salesforce. Backing up the issue instant by 60 seconds or so accommodates for the clock skew between the systems from which I am producing assertions, and Salesforce's servers.

If we had an option such as issueInstantSkewInSeconds, we could subtract this from the issue instant . Coupled with lifetimeInSeconds, we can effectively account for clock skew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant