Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML assertion signing using HSM #63

Open
troyfactor4 opened this issue Apr 14, 2020 · 1 comment · May be fixed by #64
Open

SAML assertion signing using HSM #63

troyfactor4 opened this issue Apr 14, 2020 · 1 comment · May be fixed by #64

Comments

@troyfactor4
Copy link

troyfactor4 commented Apr 14, 2020

Describe the problem you'd like to have solved

I would like to have my private key stored in my key signing server or HSM. Using an HSM server would provide greater security for the private keys.

Describe the ideal solution

The unsigned XML document should be passed to the HSM server and a signature returned to be embedded in the XML document. The private keys should never leave the HSM.

Alternatives and current work-arounds

No good workarounds are currently available.

Additional context

I have a PR ready for both node-saml and node-samlp, creating this issue just to follow protocol. The solution includes a simple upgrade to allow asynchronous XML signing using a custom function provided by the host application. Unit tests have been created and are passing. The necessary PR's have already been made to xml-crypto version 1.5.3.

May I create a PR for this issue?
My branch: https://github.com/troyfactor4/node-saml

@troyfactor4
Copy link
Author

New PR #74 created to close this issue. It is backwards compatible with the sync strategy and includes units tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants