Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): important events notifications #4644

Merged
merged 12 commits into from
Dec 27, 2022

Conversation

james-d-elliott
Copy link
Member

This sends notifications to users when they add devices.

@authelia
Copy link

authelia bot commented Dec 26, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-notify-users
  • docker pull ghcr.io/authelia/authelia:feat-notify-users

@netlify
Copy link

netlify bot commented Dec 26, 2022

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 255ea24
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/63a901645a099400086985a9
😎 Deploy Preview https://deploy-preview-4644--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #4644 (fb4cb78) into master (1c3f650) will increase coverage by 0.20%.
The diff coverage is 72.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4644      +/-   ##
==========================================
+ Coverage   67.30%   67.50%   +0.20%     
==========================================
  Files         266      266              
  Lines       19049    19124      +75     
  Branches      431      431              
==========================================
+ Hits        12820    12910      +90     
+ Misses       5482     5464      -18     
- Partials      747      750       +3     
Flag Coverage Δ
backend 67.92% <72.91%> (+0.17%) ⬆️
frontend 62.65% <ø> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/handlers/handler_register_webauthn.go 0.00% <0.00%> (ø)
internal/notification/smtp_auth.go 11.42% <0.00%> (ø)
internal/handlers/handler_register_totp.go 62.85% <33.33%> (-1.04%) ⬇️
internal/handlers/util.go 74.46% <64.70%> (-25.54%) ⬇️
internal/templates/provider.go 46.66% <66.66%> (ø)
internal/handlers/handler_reset_password_step2.go 50.00% <80.00%> (+2.17%) ⬆️
internal/templates/funcs.go 82.19% <97.61%> (+14.86%) ⬆️
internal/ntp/util.go 76.92% <0.00%> (-7.70%) ⬇️
internal/server/handlers.go 92.85% <0.00%> (+1.07%) ⬆️
...oginPortal/SecondFactor/PushNotificationMethod.tsx 68.70% <0.00%> (+6.87%) ⬆️
... and 1 more

@james-d-elliott james-d-elliott force-pushed the feat-notify-users branch 3 times, most recently from a30c98f to 0ad916e Compare December 26, 2022 12:00
@james-d-elliott james-d-elliott force-pushed the feat-notify-users branch 4 times, most recently from 5c75a5c to 89dea74 Compare December 26, 2022 13:06
@james-d-elliott james-d-elliott merged commit f685f24 into master Dec 27, 2022
@james-d-elliott james-d-elliott deleted the feat-notify-users branch December 27, 2022 08:59
@james-d-elliott james-d-elliott added this to the v4.38.0 milestone Jan 7, 2023
@james-d-elliott james-d-elliott added the area/email Email related features/bugs label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/email Email related features/bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants