fix(ntp): startup check skipped when it shouldn't be #5701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
The NTP startup check is helpful for identifying not only TOTP issues but also OpenID Connect 1.0 and Session issues. As such it should be enabled even if 2FA is disabled. Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
james-d-elliott
force-pushed
the
fix-ntp-check
branch
from
bfedbf5
to
677bae3
Compare
✅ Deploy Preview for authelia-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5701 +/- ##
==========================================
- Coverage 72.71% 72.70% -0.01%
==========================================
Files 276 276
Lines 22785 22785
Branches 438 438
==========================================
- Hits 16567 16566 -1
- Misses 5490 5491 +1
Partials 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
james-d-elliott
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NTP startup check is helpful for identifying not only TOTP issues but also OpenID Connect 1.0 and Session issues. As such it should be performed even if 2FA is disabled. This fixes this issue.