Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add WebDAV source on version 1.9.9 #351

Open
iacchi opened this issue Sep 20, 2023 · 10 comments
Open

Unable to add WebDAV source on version 1.9.9 #351

iacchi opened this issue Sep 20, 2023 · 10 comments

Comments

@iacchi
Copy link

iacchi commented Sep 20, 2023

EDIT: from the comments below it's clear that it's a general regression of version 1.9.9 and not tied to the Debian version specifically. I've edited the title accordingly.

Describe the bug
I'm running AuthPass from the Debian repository (just installed on a new computer) and I'm trying to access a key file on my personal webdav server. I enter all information correctly but when I click ok to load it I receive an error. Log of the error from the console below. The visual error within the app GUI is: Null check operator used on a null value
The mac version I've been using until yesterday works without any issues (although I created the connection a few versions ago). I've also tired to copy/paste the mac config files inside the linux version but I get other errors.

To Reproduce
Steps to reproduce the behavior:

  1. Install AuthPass on linux from the Debian repository
  2. Add WebDAV storage
  3. Enter valid WebDAV credentials
  4. See error

Expected behavior
Key files are loaded from the WebDAV source

Console error log

flutter: 2023-09-20 12:16:00.772983 SEVERE cloud_storage_ui_auth - Error while authenticating.
### _TypeError: Null check operator used on a null value
#0      WebDavProvider.propFind.<anonymous closure> (package:authpass/cloud_storage/webdav/webdav_provider.dart:189)
#1      MappedIterator.moveNext (dart:_internal/iterable.dart:393)
#2      WhereIterator.moveNext (dart:_internal/iterable.dart:440)
#3      new _GrowableList._ofOther (dart:core-patch/growable_array.dart:202)
#4      new _GrowableList.of (dart:core-patch/growable_array.dart:152)
#5      new List.of (dart:core-patch/array_patch.dart:47)
#6      SetBase.toList (dart:collection/set.dart:119)
#7      WebDavProvider.propFind (package:authpass/cloud_storage/webdav/webdav_provider.dart:197)
<asynchronous suspension>
#8      WebDavProvider.clientFromAuthenticationFlow (package:authpass/cloud_storage/webdav/webdav_provider.dart:78)
<asynchronous suspension>
#9      CloudStorageProviderClientBase.startAuth (package:authpass/cloud_storage/cloud_storage_provider.dart:319)
<asynchronous suspension>
#10     CloudStorageAuthentication._startLoginFlow (package:authpass/cloud_storage/cloud_storage_ui_auth.dart:87)
<asynchronous suspension>
#11     CloudStorageAuthentication.build.<anonymous closure> (package:authpass/cloud_storage/cloud_storage_ui_auth.dart:39)
<asynchronous suspension>

Desktop (please complete the following information):

  • OS: Debian Unstable

Additional context
Full log since opening authpass here (sorry some of it is in Italian): https://pastebin.com/Zg07SV8v

@robertoszek
Copy link

robertoszek commented Sep 27, 2023

Actually, I'm getting the same Null check operator used on a null value error on the Android app too.

Seems to be an issue introduced on the more recent versions.
After rolling back to 1.9.7+162 (via F-Droid) on Android it let me authenticate with the WebDAV source with no issues.
In Linux 1.9.7+1940 (via Flatpak) is also able to authenticate with the WebDAV source for me.

Not sure which version or commit introduced the regression but rolling back to 1.9.7 in the meantime may be worth a shot.

@iacchi
Copy link
Author

iacchi commented Sep 27, 2023

I can confirm that version 1.9.7+1941 taken from the debian repo (so installed via deb file) works. It must indeed be a general regression with version 1.9.9. I've changed the title of the issue accordingly.

@iacchi iacchi changed the title Debian repo version: unable to add WebDAV source Unable to add WebDAV source on version 1.9.9 Sep 27, 2023
@erikvanoosten
Copy link

erikvanoosten commented Sep 29, 2023

Same issue with version 1.9.9 on iphone, using Apache Httpd webdav module on the server. Unfortunately there is no way to install an earlier version on iphone.

@erikvanoosten
Copy link

The only change in authpass/lib/cloud_storage/webdav/webdav_provider.dart since the previous version is this commit. Most probably reverting this commit will fix the issue.

erikvanoosten added a commit to erikvanoosten/authpass that referenced this issue Sep 30, 2023
This reverts the change made in 4734d8f because it causes a null pointer dereference.
Fixes authpass#351.
@dpolyakov
Copy link

same error on ios17

@Osika91
Copy link

Osika91 commented Jan 28, 2024

I'm on 1.9.9+1975 version and I can't connect to the WebDAV services.

@hpoul
Copy link
Collaborator

hpoul commented Jan 29, 2024

@Osika91 imho this should be fixed. maybe you can try the latest beta: https://authpass.app/docs/help-us-beta-testing/#installation

@iacchi
Copy link
Author

iacchi commented Jan 29, 2024

I can confirm that with the build for Debian dated 27 Jan 2024 I can open my WebDAV source again. I'll test on Android asap but I guess it the bug was common to all platforms it makes sense that it's fixed on all of them.

@hpoul
Copy link
Collaborator

hpoul commented Jan 29, 2024

I guess there hasn't been a release for some platforms for quite some time.. I'll have to fix a few release scripts and try to publish everything 😅

@Osika91
Copy link

Osika91 commented Jan 29, 2024

@Osika91 imho this should be fixed. maybe you can try the latest beta: https://authpass.app/docs/help-us-beta-testing/#installation

Thanks you for your feedback. I tried the latest beta but the connection to WebDAV doesn't work. So I download the side load version 1.9.9 1992 and here the WebDAV works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants