Revert analyzer warning #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the change made in 4734d8f because it causes a null pointer dereference. Fixes authpass#351.
|
|
|
thanks for the report and diving into the problem.. to avoid the deprecation warning i think it should also work to directly access |
|
Thanks for looking into this. I am not a Flutter/Dart developer. I tried to install the tools but after 1 hour of installing problems I gave up. I was really surprised you need to install so much stuff. You even have to install malware (Chrome)! |
|
Is it possible for you build a new binary so that I can try it out? I can try it on Ubuntu (Intel), Mac (Intel) or Mac (Arm), whatever is easier for you. |
|
Closing in favor of a309d20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the change made in 4734d8f because it causes a null pointer dereference.
Fixes #351.
The only change in
authpass/lib/cloud_storage/webdav/*since the previous authpass version is this commit. Most probably reverting this commit will fix the issue.