Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap gRPC Exceptions #14

Open
jzelinskie opened this issue Jul 17, 2021 · 1 comment
Open

Wrap gRPC Exceptions #14

jzelinskie opened this issue Jul 17, 2021 · 1 comment
Labels
hint/good first issue Someone new could handle this priority/2 medium This needs to be done

Comments

@jzelinskie
Copy link
Member

Depending on whether or not the client is async, it returns entirely different exception types: RpcError and AioRpcError respectively.

The grpcutil module should have an exception type that can be used to catch both of these and handle them equivalently.
@jzelinskie jzelinskie added the priority/2 medium This needs to be done label Aug 17, 2021
@samkim samkim added the hint/good first issue Someone new could handle this label Jan 26, 2024
@intentionally-left-nil
Copy link
Contributor

Just leaving a comment that with the new SyncClient and AsyncClient it might be okay to just leave the exceptions as different. My guess is most clients will be one or the other and not mixing behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hint/good first issue Someone new could handle this priority/2 medium This needs to be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samkim @jzelinskie @intentionally-left-nil