Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to press forward button after pressing the back button #117

Open
seb86 opened this issue Feb 2, 2018 · 6 comments
Open

Unable to press forward button after pressing the back button #117

seb86 opened this issue Feb 2, 2018 · 6 comments

Comments

@seb86
Copy link
Collaborator

seb86 commented Feb 2, 2018

This issue is caused by the fix for issue #95

Needs adjusting to allow the user to press the forward button in the same manner where it auto scrolls to the next post below.

@lex111
Copy link
Collaborator

lex111 commented Feb 5, 2018

Actually, the forward button works, but only once.

Steps to reproduce:

  1. Go to the page of the post (first post)
  2. Scroll to the second post (which will automatically load)
  3. Click on the back button - you will go to the first post.
  4. Click on the button forwards - there will be a transition to the second post
  5. Press the back button again - there is a transition to the first post
  6. Press the forward button one more time - there is a transition to the second post, but the URL in the address bar of the browser did not change, it remained the URL of the first post.

I do not know how to fix it yet, seems to me you could to fix the changeURL() function, because here the thing is that the URL does not change, and because of this it becomes impossible to navigate the buttons.

@seb86
Copy link
Collaborator Author

seb86 commented Feb 5, 2018

Hi @lex111

Thank you for taking a look. I am getting different results. I think it may be to do with the History stage change. It does not always do its job. I find it gets stuck at times. The post title and URL in the address bar changes but not the post.

What browser did you try your steps with? I tried with the Firefox Quantum browser v58.0.1 (64-bit).

I also only tested with a default WordPress theme (Twenty Fifteen). What theme did you test with?

@lex111
Copy link
Collaborator

lex111 commented Feb 5, 2018

I just have problems with the address bar, strange, I thought that this is all happens because the URL does not change.

I am used Firefox 57.0.4 with a Twenty Seventeen theme.

@seb86
Copy link
Collaborator Author

seb86 commented Feb 5, 2018

Does not appear to be just the URL change so maybe something is missing with the process. Something overlooked.

@seb86
Copy link
Collaborator Author

seb86 commented Feb 5, 2018

Could it be that this line needs to move up one?

Also, if you do not scroll up a little first do you get different results when pressing the buttons due to this line?

@lex111
Copy link
Collaborator

lex111 commented Feb 5, 2018

Also, if you do not scroll up a little first do you get different results when pressing the buttons due to this line?

The result is the same, it does not affect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants