From 711bcf268cb40ec21b967bef4d0927f9de1a71ac Mon Sep 17 00:00:00 2001 From: Mark Wubben Date: Thu, 31 Dec 2020 15:48:55 +0100 Subject: [PATCH] Housekeeping * Advertise GitHub Discussions * Update issue template * Remove badges from readme * Avoid linting for every run in the test matrix. Lint with Node.js 10 only. This reduces check noise in GitHub PRs. * Update GitHub Actions --- .github/CONTRIBUTING.md | 4 ++-- .github/ISSUE_TEMPLATE/config.yml | 10 +++------- .github/workflows/ci.yml | 33 +++++++++++++++++++++---------- package.json | 3 ++- readme.md | 7 +------ 5 files changed, 31 insertions(+), 26 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 6935579b5..4b96ec216 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -41,9 +41,9 @@ We'd like to fix [`priority` issues](https://github.com/avajs/ava/labels/priorit Read on for tips on contributing code. -### Hang out in our chat +### Hang out and chat -We have a [chat](https://spectrum.chat/ava). Jump in there and lurk, talk to us, and help others. +We're using [GitHub Discussions](https://github.com/avajs/ava/discussions). Jump in there and lurk, talk to us, and help others. ## Contributing code diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 84e12671e..ebbb4df5d 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,11 +1,7 @@ blank_issues_enabled: true contact_links: + - name: Questions? Ideas? Something to share? + url: https://github.com/avajs/ava/discussions - name: Babel url: https://github.com/avajs/babel/issues - about: Ask about using Babel with AVA - - name: AVA on Spectrum - url: https://spectrum.chat/ava - about: Ask questions and discuss in our Spectrum community - - name: Stack Overflow - url: https://stackoverflow.com/questions/tagged/ava - about: Tag your question on Stack Overflow + about: Report a bug with AVA's Babel integration diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2da6efc0a..154a69900 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: node-version: [^10.18.0, ^12.14.0, ^14.0.0, ^15.0.0] os: [ubuntu-latest, windows-latest] steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 with: fetch-depth: 1 - name: Enable symlinks @@ -26,11 +26,11 @@ jobs: run: | git config core.symlinks true git reset --hard - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} - run: npm ci --no-audit - - run: npm test + - run: npm run cover - uses: codecov/codecov-action@v1 with: file: coverage/lcov.info @@ -43,10 +43,10 @@ jobs: matrix: ts-version: [~3.7.5, ~3.8, ~3.9, ~4.0, ~4.1] steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 with: fetch-depth: 1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: ^12 - run: npm ci --no-audit @@ -60,10 +60,10 @@ jobs: name: Test package-lock for unexpected modifications runs-on: ubuntu-latest steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 with: fetch-depth: 1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: ^12.14.0 - name: Upgrade npm @@ -83,11 +83,24 @@ jobs: name: Install dependencies without using a lockfile runs-on: ubuntu-latest steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 with: fetch-depth: 1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: node-version: ^12.14.0 - run: npm install --no-shrinkwrap --no-audit - - run: npm test + - run: npm run cover + + xo: + name: Lint source files + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 1 + - uses: actions/setup-node@v2 + with: + node-version: ^10.18.0 + - run: npm ci + - run: npx xo diff --git a/package.json b/package.json index 892f8051f..7a97488fa 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,8 @@ "node": ">=10.18.0 <11 || >=12.14.0 <12.17.0 || >=12.17.0 <13 || >=14.0.0 <15 || >=15" }, "scripts": { - "test": "xo && tsd && c8 --report=none tap && c8 --report=none --no-clean test-ava && c8 report" + "cover": "c8 --report=none tap && c8 --report=none --no-clean test-ava && c8 report", + "test": "xo && tsd && npm run -s cover" }, "files": [ "lib", diff --git a/readme.md b/readme.md index 9f619ac1d..e2a8f75d2 100644 --- a/readme.md +++ b/readme.md @@ -1,8 +1,5 @@ # AVA logo -[![Build Status](https://travis-ci.org/avajs/ava.svg?branch=master)](https://travis-ci.org/avajs/ava) [![Coverage Status](https://codecov.io/gh/avajs/ava/branch/master/graph/badge.svg)](https://codecov.io/gh/avajs/ava/branch/master) [![XO code style](https://img.shields.io/badge/code_style-XO-5ed9c7.svg)](https://github.com/xojs/xo) [![Join the community on Spectrum](https://withspectrum.github.io/badge/badge.svg)](https://spectrum.chat/ava) -[![Mentioned in Awesome Node.js](https://awesome.re/mentioned-badge.svg)](https://github.com/sindresorhus/awesome-nodejs) - AVA is a test runner for Node.js with a concise API, detailed error output, embrace of new language features and process isolation that lets you develop with confidence 🚀 Follow the [AVA Twitter account](https://twitter.com/ava__js) for updates. @@ -188,9 +185,7 @@ It's the [Andromeda galaxy](https://simple.wikipedia.org/wiki/Andromeda_galaxy). ## Support -- [Stack Overflow](https://stackoverflow.com/questions/tagged/ava) -- [Spectrum](https://spectrum.chat/ava) -- [Twitter](https://twitter.com/ava__js) +- [GitHub Discussions](https://github.com/avajs/ava/discussions) ## Related