Remove @types/node reference

novemberborn · web-flow · commit 7a1dacf369a5 · 2020-02-16T13:03:49.000+01:00
Fixes #2397. * Remove @types/node reference from our TypeScript definition * Ensure our TypeScript tests don't use any installed types * Adjust our TypeScript test target to ES2018
diff --git a/index.d.ts b/index.d.ts
@@ -1,5 +1,3 @@
-/// <reference types="node"/>
-
 export interface Subscribable {
 	subscribe(observer: {
 		error(err: any): void,
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -112,7 +112,6 @@
 	},
 	"devDependencies": {
 		"@ava/babel": "^1.0.1",
-		"@types/node": "^10.17.13",
 		"ansi-escapes": "^4.3.0",
 		"delay": "^4.3.0",
 		"esm": "^3.2.25",
diff --git a/test/ts-types/tsconfig.json b/test/ts-types/tsconfig.json
@@ -1,7 +1,8 @@
 {
 	"compilerOptions": {
 		"module": "commonjs",
-		"target": "es2017",
+		"target": "es2018",
+		"types": [],
 		"strict": true
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/// <reference types="node"/>`
`2`		`-`
`3`	`1`	`export interface Subscribable {`
`4`	`2`	`subscribe(observer: {`
`5`	`3`	`error(err: any): void,`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
`3`	`3`	`"module": "commonjs",`
`4`		`- "target": "es2017",`
	`4`	`+ "target": "es2018",`
	`5`	`+ "types": [],`
`5`	`6`	`"strict": true`
`6`	`7`	`}`
`7`	`8`	`}`