From 7a1dacf369a5857309effa42fc1638d7b8fe4ead Mon Sep 17 00:00:00 2001 From: Mark Wubben Date: Sun, 16 Feb 2020 13:03:49 +0100 Subject: [PATCH] Remove @types/node reference Fixes #2397. * Remove @types/node reference from our TypeScript definition * Ensure our TypeScript tests don't use any installed types * Adjust our TypeScript test target to ES2018 --- index.d.ts | 2 -- package-lock.json | 6 ------ package.json | 1 - test/ts-types/tsconfig.json | 3 ++- 4 files changed, 2 insertions(+), 10 deletions(-) diff --git a/index.d.ts b/index.d.ts index c01195115..44ca5a4e2 100644 --- a/index.d.ts +++ b/index.d.ts @@ -1,5 +1,3 @@ -/// - export interface Subscribable { subscribe(observer: { error(err: any): void, diff --git a/package-lock.json b/package-lock.json index 4dbc61f26..481b21216 100644 --- a/package-lock.json +++ b/package-lock.json @@ -589,12 +589,6 @@ "resolved": "https://registry.npmjs.org/@types/minimatch/-/minimatch-3.0.3.tgz", "integrity": "sha512-tHq6qdbT9U1IRSGf14CL0pUlULksvY9OZ+5eEgl1N7t+OA3tGvNpxJCzuKQlsNgCVwbAs670L1vcVQi8j9HjnA==" }, - "@types/node": { - "version": "10.17.13", - "resolved": "https://registry.npmjs.org/@types/node/-/node-10.17.13.tgz", - "integrity": "sha512-pMCcqU2zT4TjqYFrWtYHKal7Sl30Ims6ulZ4UFXxI4xbtQqK/qqKwkDoBFCfooRqqmRu9vY3xaJRwxSh673aYg==", - "dev": true - }, "@types/normalize-package-data": { "version": "2.4.0", "resolved": "https://registry.npmjs.org/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz", diff --git a/package.json b/package.json index e5e3f205e..2cac0153d 100644 --- a/package.json +++ b/package.json @@ -112,7 +112,6 @@ }, "devDependencies": { "@ava/babel": "^1.0.1", - "@types/node": "^10.17.13", "ansi-escapes": "^4.3.0", "delay": "^4.3.0", "esm": "^3.2.25", diff --git a/test/ts-types/tsconfig.json b/test/ts-types/tsconfig.json index c6cf0468b..e9e8b18a5 100644 --- a/test/ts-types/tsconfig.json +++ b/test/ts-types/tsconfig.json @@ -1,7 +1,8 @@ { "compilerOptions": { "module": "commonjs", - "target": "es2017", + "target": "es2018", + "types": [], "strict": true } }