Use absolute source map paths in precompiled files

kugtong33 · novemberborn · commit aaddc37a72ce · 2018-01-16T17:03:44.000Z
diff --git a/lib/caching-precompiler.js b/lib/caching-precompiler.js
@@ -76,9 +76,7 @@ class CachingPrecompiler {
 
 		// Append source map comment to transformed code
 		// So that other libraries (like nyc) can find the source map
-		const dirPath = path.dirname(filePath);
-		const relativeMapPath = path.relative(dirPath, mapPath);
-		const comment = convertSourceMap.generateMapFileComment(relativeMapPath);
+		const comment = convertSourceMap.generateMapFileComment(mapPath);
 
 		return `${result.code}\n${comment}`;
 	}
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -90,7 +90,7 @@
 		"code-excerpt": "^2.1.0",
 		"common-path-prefix": "^1.0.0",
 		"concordance": "^3.0.0",
-		"convert-source-map": "^1.2.0",
+		"convert-source-map": "^1.5.1",
 		"core-assert": "^0.2.0",
 		"currently-unhandled": "^0.4.1",
 		"debug": "^3.0.1",

Original file line number	Diff line number	Diff line change
`@@ -76,9 +76,7 @@ class CachingPrecompiler {`
`76`	`76`
`77`	`77`	`// Append source map comment to transformed code`
`78`	`78`	`// So that other libraries (like nyc) can find the source map`
`79`		`- const dirPath = path.dirname(filePath);`
`80`		`- const relativeMapPath = path.relative(dirPath, mapPath);`
`81`		`- const comment = convertSourceMap.generateMapFileComment(relativeMapPath);`
	`79`	`+ const comment = convertSourceMap.generateMapFileComment(mapPath);`
`82`	`80`
`83`	`81`	return `${result.code}\n${comment}`;
`84`	`82`	`}`