Skip to content

Commit b3866b6

Browse files
m5x5novemberborn
andauthoredJun 14, 2020
Merge mini and verbose reporter implementations
Co-authored-by: Mark Wubben <mark@novemberborn.net>
1 parent f5e1f94 commit b3866b6

File tree

6 files changed

+915
-1116
lines changed

6 files changed

+915
-1116
lines changed
 

‎lib/cli.js

+4-11
Original file line numberDiff line numberDiff line change
@@ -259,8 +259,7 @@ exports.run = async () => { // eslint-disable-line complexity
259259

260260
const ciParallelVars = require('ci-parallel-vars');
261261
const Api = require('./api');
262-
const VerboseReporter = require('./reporters/verbose');
263-
const MiniReporter = require('./reporters/mini');
262+
const DefaultReporter = require('./reporters/default');
264263
const TapReporter = require('./reporters/tap');
265264
const Watcher = require('./watcher');
266265
const normalizeExtensions = require('./extensions');
@@ -391,19 +390,13 @@ exports.run = async () => { // eslint-disable-line complexity
391390
reportStream: process.stdout,
392391
stdStream: process.stderr
393392
});
394-
} else if (debug !== null || combined.verbose || isCi || !process.stdout.isTTY) {
395-
reporter = new VerboseReporter({
396-
projectDir,
397-
reportStream: process.stdout,
398-
stdStream: process.stderr,
399-
watching: combined.watch
400-
});
401393
} else {
402-
reporter = new MiniReporter({
394+
reporter = new DefaultReporter({
403395
projectDir,
404396
reportStream: process.stdout,
405397
stdStream: process.stderr,
406-
watching: combined.watch
398+
watching: combined.watch,
399+
verbose: debug !== null || combined.verbose || isCi || !process.stdout.isTTY
407400
});
408401
}
409402

‎lib/reporters/default.js

+904
Large diffs are not rendered by default.

‎lib/reporters/mini.js

-628
This file was deleted.

‎lib/reporters/verbose.js

-473
This file was deleted.

‎test-tap/reporters/mini.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const path = require('path');
1010
const {test} = require('tap');
1111
const TTYStream = require('../helper/tty-stream');
1212
const report = require('../helper/report');
13-
const MiniReporter = require('../../lib/reporters/mini');
13+
const Reporter = require('../../lib/reporters/default');
1414

1515
const run = (type, sanitizers = []) => t => {
1616
t.plan(1);
@@ -21,7 +21,7 @@ const run = (type, sanitizers = []) => t => {
2121
columns: 200,
2222
sanitizers: [...sanitizers, report.sanitizers.cwd, report.sanitizers.experimentalWarning, report.sanitizers.posix, report.sanitizers.version]
2323
});
24-
const reporter = new MiniReporter({
24+
const reporter = new Reporter({
2525
projectDir: report.projectDir(type),
2626
spinner: {
2727
interval: 60 * 60 * 1000, // No need to update the spinner
@@ -32,6 +32,7 @@ const run = (type, sanitizers = []) => t => {
3232
stdStream: tty,
3333
watching: type === 'watch'
3434
});
35+
3536
return report[type](reporter)
3637
.then(() => {
3738
tty.end();

‎test-tap/reporters/verbose.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const {test} = require('tap');
44
const {restoreClock} = require('../helper/fix-reporter-env')();
55
const TTYStream = require('../helper/tty-stream');
66
const report = require('../helper/report');
7-
const VerboseReporter = require('../../lib/reporters/verbose');
7+
const Reporter = require('../../lib/reporters/default');
88

99
const run = (type, sanitizers = []) => t => {
1010
t.plan(1);
@@ -15,13 +15,15 @@ const run = (type, sanitizers = []) => t => {
1515
columns: 200,
1616
sanitizers: [...sanitizers, report.sanitizers.cwd, report.sanitizers.experimentalWarning, report.sanitizers.posix, report.sanitizers.version]
1717
});
18-
const reporter = new VerboseReporter({
18+
const reporter = new Reporter({
1919
projectDir: report.projectDir(type),
2020
durationThreshold: 60000,
2121
reportStream: tty,
2222
stdStream: tty,
23+
verbose: true,
2324
watching: type === 'watch'
2425
});
26+
2527
return report[type](reporter)
2628
.then(() => {
2729
tty.end();

0 commit comments

Comments
 (0)
Please sign in to comment.