Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples now use AVA 4 #3017

Closed
wants to merge 1 commit into from
Closed

Examples now use AVA 4 #3017

wants to merge 1 commit into from

Conversation

Timethor
Copy link

Resolves #2993

  • I've updated some of the examples to "module", while others were left as "commonjs" ... thought it would be good to see both
  • Seemed like I needed a ava.config.js file for most examples (assuming this is for monorepo behavior mentioned in the ESM Support sections of 4.X releases). If there's a more preferred way please let me know and I'll update
  • Any new examples you'd like me to create for new v4 features, more than willing... still catching up, last used AVA when it was v1-v2

@novemberborn
Copy link
Member

@Timethor nice!

  • I've updated some of the examples to "module", while others were left as "commonjs" ... thought it would be good to see both

I suppose, but I don't think it's helpful to see a CommonJS test that then needs to use a dynamic import() for an ES module.

  • Seemed like I needed a ava.config.js file for most examples (assuming this is for monorepo behavior mentioned in the ESM Support sections of 4.X releases). If there's a more preferred way please let me know and I'll update

Ha, yes that makes sense actually. You could export default {} though, there shouldn't be a need to override any of the defaults.

  • Any new examples you'd like me to create for new v4 features, more than willing... still catching up, last used AVA when it was v1-v2

Hmm, I'm not sure how full the coverage of v3 features was. Let's assume 100% and then we could have a look at the changelog since?

@novemberborn
Copy link
Member

Hi @Timethor, would you have time to get back to this?

@novemberborn
Copy link
Member

Line number selection may no longer work in StackBlitz with AVA 4, see #3049 (comment). Source maps now come from Node.js and we're seeing https:// URLs which AVA isn't meant to deal with.

@Timethor
Copy link
Author

@novemberborn Sorry, nearly forgot about this, been a crazy few months. Will be getting some spare time in a week or two 🙃

@novemberborn
Copy link
Member

No worries @Timethor!

@novemberborn
Copy link
Member

Closing due to inactivity. We'd be happy to pick this up again when you have the time to get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples use AVA 3
2 participants