Drop Node.js 16, upgrade minimal 18 and 20, test 21 #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
novemberborn
commented
Oct 22, 2023
novemberborn
commented
- Drop support for Node.js 16
- Change expected Node.js 18 to 18.18
- Change expected Node.js 20 to 20.8
- Add Node.js 21 to the test matrix
novemberborn
force-pushed
the
update-nodes
branch
from
92512c8
to
a7c1142
Compare
The snapshots are compressed differently in Node.js 21. The compression has been stable for many versions but that is not a guarantee, see nodejs/node#50138 for background. Change tests to compare the decompressed data instead.
novemberborn
force-pushed
the
update-nodes
branch
from
a7c1142
to
922bc91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.