From 178201e07cd7e5e92ed3605b298119cda725712e Mon Sep 17 00:00:00 2001 From: il3ven Date: Mon, 9 May 2022 00:51:10 +0530 Subject: [PATCH 1/4] report number of timeouts in test summary --- lib/reporters/default.js | 4 ++++ lib/run-status.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/reporters/default.js b/lib/reporters/default.js index bc74d5c02..ebea53db5 100644 --- a/lib/reporters/default.js +++ b/lib/reporters/default.js @@ -659,6 +659,10 @@ export default class Reporter { this.lineWriter.writeLine(colors.error(`${this.stats.uncaughtExceptions} uncaught ${plur('exception', this.stats.uncaughtExceptions)}`)); } + if (this.stats.timeouts > 0) { + this.lineWriter.writeLine(colors.error(`${this.stats.timeouts} ${plur('test', this.stats.timeouts)} remained pending after a timeout`)); + } + if (this.previousFailures > 0) { this.lineWriter.writeLine(colors.error(`${this.previousFailures} previous ${plur('failure', this.previousFailures)} in test files that were not rerun`)); } diff --git a/lib/run-status.js b/lib/run-status.js index a18f4e1af..caaf426e9 100644 --- a/lib/run-status.js +++ b/lib/run-status.js @@ -125,7 +125,7 @@ export default class RunStatus extends Emittery { case 'timeout': event.pendingTests = this.pendingTests; this.pendingTests = new Map(); - stats.timeouts++; + event.pendingTests.forEach((testsInFile) => stats.timeouts += testsInFile.size); break; case 'interrupt': event.pendingTests = this.pendingTests; From 1c2b914a185dc30cd4aba4cdbbe6bd73763159ff Mon Sep 17 00:00:00 2001 From: il3ven Date: Mon, 9 May 2022 01:06:59 +0530 Subject: [PATCH 2/4] update .log files --- test-tap/reporters/default.timeoutinmultiplefiles.v12.log | 1 + test-tap/reporters/default.timeoutinmultiplefiles.v14.log | 1 + test-tap/reporters/default.timeoutinmultiplefiles.v16.log | 1 + test-tap/reporters/default.timeoutinmultiplefiles.v17.log | 1 + test-tap/reporters/default.timeoutinsinglefile.v12.log | 1 + test-tap/reporters/default.timeoutinsinglefile.v14.log | 1 + test-tap/reporters/default.timeoutinsinglefile.v16.log | 1 + test-tap/reporters/default.timeoutinsinglefile.v17.log | 1 + test-tap/reporters/default.timeoutwithmatch.v12.log | 1 + test-tap/reporters/default.timeoutwithmatch.v14.log | 1 + test-tap/reporters/default.timeoutwithmatch.v16.log | 1 + test-tap/reporters/default.timeoutwithmatch.v17.log | 1 + 12 files changed, 12 insertions(+) diff --git a/test-tap/reporters/default.timeoutinmultiplefiles.v12.log b/test-tap/reporters/default.timeoutinmultiplefiles.v12.log index dbc999ffd..16d1ddd6b 100644 --- a/test-tap/reporters/default.timeoutinmultiplefiles.v12.log +++ b/test-tap/reporters/default.timeoutinmultiplefiles.v12.log @@ -30,4 +30,5 @@ ─ 4 tests passed + 5 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutinmultiplefiles.v14.log b/test-tap/reporters/default.timeoutinmultiplefiles.v14.log index dbc999ffd..16d1ddd6b 100644 --- a/test-tap/reporters/default.timeoutinmultiplefiles.v14.log +++ b/test-tap/reporters/default.timeoutinmultiplefiles.v14.log @@ -30,4 +30,5 @@ ─ 4 tests passed + 5 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutinmultiplefiles.v16.log b/test-tap/reporters/default.timeoutinmultiplefiles.v16.log index dbc999ffd..16d1ddd6b 100644 --- a/test-tap/reporters/default.timeoutinmultiplefiles.v16.log +++ b/test-tap/reporters/default.timeoutinmultiplefiles.v16.log @@ -30,4 +30,5 @@ ─ 4 tests passed + 5 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutinmultiplefiles.v17.log b/test-tap/reporters/default.timeoutinmultiplefiles.v17.log index dbc999ffd..16d1ddd6b 100644 --- a/test-tap/reporters/default.timeoutinmultiplefiles.v17.log +++ b/test-tap/reporters/default.timeoutinmultiplefiles.v17.log @@ -30,4 +30,5 @@ ─ 4 tests passed + 5 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutinsinglefile.v12.log b/test-tap/reporters/default.timeoutinsinglefile.v12.log index 43c2cbffa..3c4830fb5 100644 --- a/test-tap/reporters/default.timeoutinsinglefile.v12.log +++ b/test-tap/reporters/default.timeoutinsinglefile.v12.log @@ -16,4 +16,5 @@ ─ 2 tests passed + 2 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutinsinglefile.v14.log b/test-tap/reporters/default.timeoutinsinglefile.v14.log index 43c2cbffa..3c4830fb5 100644 --- a/test-tap/reporters/default.timeoutinsinglefile.v14.log +++ b/test-tap/reporters/default.timeoutinsinglefile.v14.log @@ -16,4 +16,5 @@ ─ 2 tests passed + 2 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutinsinglefile.v16.log b/test-tap/reporters/default.timeoutinsinglefile.v16.log index 43c2cbffa..3c4830fb5 100644 --- a/test-tap/reporters/default.timeoutinsinglefile.v16.log +++ b/test-tap/reporters/default.timeoutinsinglefile.v16.log @@ -16,4 +16,5 @@ ─ 2 tests passed + 2 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutinsinglefile.v17.log b/test-tap/reporters/default.timeoutinsinglefile.v17.log index 43c2cbffa..3c4830fb5 100644 --- a/test-tap/reporters/default.timeoutinsinglefile.v17.log +++ b/test-tap/reporters/default.timeoutinsinglefile.v17.log @@ -16,4 +16,5 @@ ─ 2 tests passed + 2 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutwithmatch.v12.log b/test-tap/reporters/default.timeoutwithmatch.v12.log index e64e4e60f..2ed31ca03 100644 --- a/test-tap/reporters/default.timeoutwithmatch.v12.log +++ b/test-tap/reporters/default.timeoutwithmatch.v12.log @@ -14,4 +14,5 @@ ─ 1 test passed + 2 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutwithmatch.v14.log b/test-tap/reporters/default.timeoutwithmatch.v14.log index e64e4e60f..2ed31ca03 100644 --- a/test-tap/reporters/default.timeoutwithmatch.v14.log +++ b/test-tap/reporters/default.timeoutwithmatch.v14.log @@ -14,4 +14,5 @@ ─ 1 test passed + 2 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutwithmatch.v16.log b/test-tap/reporters/default.timeoutwithmatch.v16.log index e64e4e60f..2ed31ca03 100644 --- a/test-tap/reporters/default.timeoutwithmatch.v16.log +++ b/test-tap/reporters/default.timeoutwithmatch.v16.log @@ -14,4 +14,5 @@ ─ 1 test passed + 2 tests remained pending after a timeout ---tty-stream-chunk-separator diff --git a/test-tap/reporters/default.timeoutwithmatch.v17.log b/test-tap/reporters/default.timeoutwithmatch.v17.log index e64e4e60f..2ed31ca03 100644 --- a/test-tap/reporters/default.timeoutwithmatch.v17.log +++ b/test-tap/reporters/default.timeoutwithmatch.v17.log @@ -14,4 +14,5 @@ ─ 1 test passed + 2 tests remained pending after a timeout ---tty-stream-chunk-separator From 7f72e89287b5bfb9d54d566cd0739972db4d33b4 Mon Sep 17 00:00:00 2001 From: il3ven Date: Mon, 9 May 2022 01:30:19 +0530 Subject: [PATCH 3/4] lint fix --- lib/run-status.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/run-status.js b/lib/run-status.js index caaf426e9..b6128cda7 100644 --- a/lib/run-status.js +++ b/lib/run-status.js @@ -125,7 +125,10 @@ export default class RunStatus extends Emittery { case 'timeout': event.pendingTests = this.pendingTests; this.pendingTests = new Map(); - event.pendingTests.forEach((testsInFile) => stats.timeouts += testsInFile.size); + for (const [, testsInFile] of event.pendingTests.entries()) { + stats.timeouts += testsInFile.size; + } + break; case 'interrupt': event.pendingTests = this.pendingTests; From f7b8a2b69fd33ee4a5d1ae5f8e52465cf28a8c41 Mon Sep 17 00:00:00 2001 From: Mark Wubben Date: Mon, 16 May 2022 10:56:21 +0200 Subject: [PATCH 4/4] Access map values --- lib/run-status.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/run-status.js b/lib/run-status.js index b6128cda7..7d6b26c01 100644 --- a/lib/run-status.js +++ b/lib/run-status.js @@ -125,7 +125,7 @@ export default class RunStatus extends Emittery { case 'timeout': event.pendingTests = this.pendingTests; this.pendingTests = new Map(); - for (const [, testsInFile] of event.pendingTests.entries()) { + for (const testsInFile of event.pendingTests.values()) { stats.timeouts += testsInFile.size; }