Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new file and helper selection #238

Closed
novemberborn opened this issue Apr 28, 2019 · 2 comments
Closed

Support new file and helper selection #238

novemberborn opened this issue Apr 28, 2019 · 2 comments

Comments

@novemberborn
Copy link
Member

avajs/ava#2103 changes how test files and helpers are selected. This impacts our no-ignored-test-files and no-import-test-files rules.

I suggest we add an eslint-helper file to the main ava package. It should take care of reading the config (accepting a project directory argument). The rules should then be able to call a function to determine whether something is a test or helper file.

There may be other places where we try to resolve AVA config. We should move those to ava/eslint-helper as well.

@sindresorhus
Copy link
Member

@novemberborn Was this fixed by df6374a?

@novemberborn
Copy link
Member Author

Yes, well spotted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants