Respect name option when CACHE_DIR environment variable is set
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus Whom shall I ask for a review? |
index.js
Outdated
| @@ -43,7 +43,7 @@ function getNodeModuleDirectory(directory) { | |||
|
|
|||
| module.exports = (options = {}) => { | |||
| if (env.CACHE_DIR && !['true', 'false', '1', '0'].includes(env.CACHE_DIR)) { | |||
| return useDirectory(path.join(env.CACHE_DIR, 'find-cache-dir'), options); | |||
| return useDirectory(path.join(env.CACHE_DIR, options.name || 'find-cache-dir'), options); | |||
There was a problem hiding this comment.
The || is moot as the name option is documented as "required".
There was a problem hiding this comment.
Suggested change
| return useDirectory(path.join(env.CACHE_DIR, options.name || 'find-cache-dir'), options); | |
| return useDirectory(path.join(env.CACHE_DIR, options.name), options); |
There was a problem hiding this comment.
I'm not sure why is was set to find-cache-dir in the first place, appears to be an error that was never caught by the unit tests since the code was never tested under a different package name.
|
// @Richienb |
Richienb
reviewed
Aug 27, 2021
test.js
Outdated
| delete process.env.CACHE_DIR; | ||
| }); | ||
|
|
||
| test('respects options.name when CACHE_DIR is set', t => { | ||
| const newCacheDirectory = tempDirectory(); | ||
| const finalDirectory = path.join(newCacheDirectory, 'babel-loader'); |
There was a problem hiding this comment.
Just a small nitpick: Might be best to use a more generic package name for posterity.
alexanderGerbik
force-pushed
the
master
branch
from
b350b3f
to
483b015
Compare
Richienb
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.