Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform mem usage to Redis even if not using RM_Alloc #2

Open
aviggiano opened this issue May 9, 2017 · 1 comment
Open

Inform mem usage to Redis even if not using RM_Alloc #2

aviggiano opened this issue May 9, 2017 · 1 comment
Labels
bug help wanted

Comments

@aviggiano
Copy link
Owner

aviggiano commented May 9, 2017 •
edited

Since CRoaring handles all memory allocations, we can't use redis modules allocation wrappers.

It seems it isn't possible to proactively inform redis the current Redis Modules API, but perhaps they might be interested in a pull request.
@aviggiano aviggiano changed the title See if we can inform MemUsage instead of using RM_Alloc Inform mem usage to Redis even if not using RM_Alloc May 9, 2017
aviggiano added a commit that referenced this issue May 20, 2017
@aviggiano
Add memory integration tests
c66ec00 
Will use them to confirm allocation override changes redis memory report
(#2)
@aviggiano aviggiano mentioned this issue Jun 24, 2017
Closed
@aviggiano aviggiano added the bug label Aug 15, 2017
@aviggiano aviggiano mentioned this issue Aug 29, 2017
Closed
@aviggiano aviggiano mentioned this issue Sep 28, 2020
Open
@aviggiano aviggiano mentioned this issue Oct 23, 2020
Merged
@aviggiano
Copy link
Owner Author

This should've been done with #66, so in theory we only need to check if the issue still exists

@aviggiano aviggiano mentioned this issue Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Inform memory usage to redis aviggiano/redis-roaring
1 participant
@aviggiano