Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Mermaid diagrams from an included .mermaid-file #448

Open
mcbeelen opened this issue Mar 6, 2024 · 4 comments
Open

Render Mermaid diagrams from an included .mermaid-file #448

mcbeelen opened this issue Mar 6, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mcbeelen
Copy link

mcbeelen commented Mar 6, 2024

User store

In order to being able to reuse diagrams and keep code isolated
As a site developer
I want to be able to include mermaid diagrams from source-files

If I want o render a mermaid diagram in the generated site the diagram as text currently has to be inside the

Current

[mermaid]
----
graph TD;
A-->B;
A-->C;
B-->D;
C-->D;

Wanted

[mermaid]
----
include::flow.mermaid[]

First attempt

Mar 05, 2024 8:40:48 AM uri:classloader:/gems/asciidoctor-2.0.20/lib/asciidoctor/reader.rb preprocess_include_directive
SEVERE: <stdin>: line 8: include file not found: /var/model/flow.mermaid
Mar 05, 2024 8:40:48 AM uri:classloader:/gems/asciidoctor-2.0.20/lib/asciidoctor/reader.rb preprocess_include_directive
SEVERE: <stdin>: line 8: include file not found: /var/model/flow.mermaid
Mar 05, 2024 8:40:48 AM uri:classloader:/gems/asciidoctor-2.0.20/lib/asciidoctor/reader.rb preprocess_include_directive
SEVERE: <stdin>: line 8: include file not found: /var/model/flow.mermaid
Mar 05, 2024 8:40:48 AM uri:classloader:/gems/asciidoctor-2.0.20/lib/asciidoctor/reader.rb preprocess_include_directive
SEVERE: <stdin>: line 8: include file not found: /var/model/flow.mermaid

References

@mcbeelen
Copy link
Author

mcbeelen commented Mar 8, 2024

In the workspace.dsl I have !docs docs
The fact that the .adoc-file and the included file reside in a subdirectory is lost when triggering the processing of the .adoc-file.

I'm running the site generator using docker on windows.
docker run -it --rm -p 8080:8080 -v %CD%:/var/model ghcr.io/avisi-cloud/structurizr-site-generatr generate-site -w workspace.dsl

@jp7677
Copy link
Collaborator

jp7677 commented Mar 8, 2024

This scenario is indeed currently not supported, see https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/src/main/kotlin/nl/avisi/structurizr/site/generatr/site/model/ToHtml.kt#L84

Since you are familiar with the topic and setup for this, any chance your could create a PR for this?

@mcbeelen
Copy link
Author

@jp7677

I did some research into this topic in order to create a PR, but I fail to see a path forward. The problem I see is that there is a separation between the moment where the .adoc-files are being read and where the asciidocToHtml is being done.

Reading the files is being done as part of the Structurizr DSL DocsParser
The parsed workspace is handed down towards the asciidocToHtml function of the SiteGenerator
The comments in that function already indicate the wish to support partial includes.

The AsciiDoctor Options does not support setting a different basePath.

A possible solution could be found in a custom implementation of the DocumentationImporter and adjust the DSL to trigger the DocsParser to use that one.

The custom implementation might be given the responsibility to preprocess the content, resolve the includes and inline the partials into the content of the documentation. This would be aligned with the statement in the AsciiDoc documentation about include being a preprocessor directive

@jp7677
Copy link
Collaborator

jp7677 commented Mar 17, 2024

Thanks for the assessment, yeah, looks like a non-trivial feature to implement correctly. Unfortunately we don't use AsciiDoc internally, so I would prefer if this is added by someone who is actually using this feature and knows how to use this in real life. The initial support for AsciiDoc was also a contribution. Sorry.

@jp7677 jp7677 added help wanted Extra attention is needed enhancement New feature or request labels Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants