Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer file.Close #78

Conversation

OladapoAjala
Copy link
Contributor

Closes #25

@OladapoAjala OladapoAjala mentioned this pull request Aug 8, 2022
@awalterschulze
Copy link
Owner

This is a vendored dependency, so we ideally do not want to modify it.

The idea of the defer.Close issue, is to create a plugin that generates some code that would, make it easy to properly handle closing files and the errors better than defer does, but just as conveniently, not fix the issues we have.

Fixing how we handle file.Close is on table though, but not to close the issue, simply to make our code more reliable.

@awalterschulze
Copy link
Owner

Sorry about the confusion, the issue isn't described very clearly

@OladapoAjala
Copy link
Contributor Author

OladapoAjala commented Aug 8, 2022

No worries, I think the goal to effectively work on the open issues and have them closed ASAP so helping clarify open issues suffices too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defer file.Close
2 participants